Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #121

Closed
wants to merge 2 commits into from
Closed

Performance improvements #121

wants to merge 2 commits into from

Conversation

cokicm
Copy link

@cokicm cokicm commented Feb 17, 2024

Description

Multiple performance improvements:
- Pooling of big.Int instances on the stack to avoid frequent allocations/cleanup
- Removing unnecessary big.Int allocation in pop() method and fixing tests
- Avoiding unnecessary op.String() calls when tracer is not initialized.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Since there is not yet official performance framework, I have tested this fix with custom code.

- Pooling of big.Int instances on the stack to avoid frequent allocations/cleanup
- Removing unnecessary big.Int allocation in pop() method and fixing tests
- Avoiding unnecessary op.String() calls when tracer is not initialized.
@cokicm cokicm self-assigned this Feb 17, 2024
@cokicm cokicm changed the base branch from develop to london-tests-fix February 18, 2024 08:23
helper/common/common_test.go Show resolved Hide resolved
helper/common/common_test.go Show resolved Hide resolved
helper/common/common_test.go Show resolved Hide resolved
helper/common/common_test.go Show resolved Hide resolved
helper/common/common_test.go Show resolved Hide resolved
helper/common/common_test.go Show resolved Hide resolved
helper/common/common.go Show resolved Hide resolved
@goran-ethernal goran-ethernal deleted the branch Ethernal-Tech:london-tests-fix February 19, 2024 10:17
@cokicm cokicm deleted the performance-improvements branch February 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants