Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added constructor for all types of transactions #153

Merged
merged 6 commits into from
Mar 14, 2024
Merged

added constructor for all types of transactions #153

merged 6 commits into from
Mar 14, 2024

Conversation

dusannosovic-ethernal
Copy link

@dusannosovic-ethernal dusannosovic-ethernal commented Mar 12, 2024 •
edited
Loading

Description

This PR includes contructor functions for all types of transactions dynamicTx, stateTx, etc.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusannosovic-ethernal dusannosovic-ethernal changed the title added contructor for all types of transactions added constructor for all types of transactions Mar 12, 2024
@dusannosovic-ethernal dusannosovic-ethernal self-assigned this Mar 13, 2024
@dusannosovic-ethernal dusannosovic-ethernal marked this pull request as ready for review March 13, 2024 13:01
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the baseTx-contructor-function branch from 20a2862 to d5377e3 Compare March 13, 2024 13:02
goran-ethernal
goran-ethernal previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for that small comment, LGTM.

types/transaction.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal merged commit 6501516 into develop Mar 14, 2024
10 checks passed
@goran-ethernal goran-ethernal deleted the baseTx-contructor-function branch March 14, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees

@dusannosovic-ethernal dusannosovic-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusannosovic-ethernal @goran-ethernal