TLS certificate on CI #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visnja
reviewed
Mar 15, 2024
| @@ -133,8 +133,8 @@ func (j *JSONRPC) setupHTTP() error { | |||
| } | |||
|
|
|||
| if j.config.TLSCertFile != "" && j.config.TLSKeyFile != "" { | |||
| j.logger.Info("https cert file", j.config.TLSCertFile) | |||
| j.logger.Info("https key file", j.config.TLSKeyFile) | |||
| j.logger.Info("TLS", "cert file", j.config.TLSCertFile) | |||
visnja
reviewed
Mar 15, 2024
| j.logger.Info("https cert file", j.config.TLSCertFile) | ||
| j.logger.Info("https key file", j.config.TLSKeyFile) | ||
| j.logger.Info("TLS", "cert file", j.config.TLSCertFile) | ||
| j.logger.Info("TLS", "key file", j.config.TLSKeyFile) |
There was a problem hiding this comment.
Yes, because that way we can see what files are exactly used as certificate files. It is important for troubleshooting, if something is not working we can quickly check what files are given as certificate files.
bane
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it