TestE2E_Consensus_RegisterValidator fix #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverbundalo
requested review from
Stefan-Ethernal,
goran-ethernal and
dusannosovic-ethernal
Stefan-Ethernal
approved these changes
May 31, 2024
| Stake *big.Int `json:"stake"` | ||
| WithdrawableRewards *big.Int `json:"withdrawableRewards"` | ||
| Address types.Address `json:"address"` |
There was a problem hiding this comment.
I've quickly checked, we should be fine with this change (in terms there is no fear that it is a breaking change).
goran-ethernal
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestE2E_Consensus_RegisterValidator e2e test fixed in order to wait at least 1 block before asserts, otherwise it happens that block is not synced yet when check for 2nd validator is executed. In addition changed fields order in ValidatorInfo struct in order to reduce size from 48 to 40 bytes.
Changes include
Checklist
Testing