Refactor configuration #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General * User __name__ as logger name everywhere '$participants' command: * Move from extension module to simple cog * Use dynamic role list instead of hard-coded role names * Add channel visibility check bot.py * Simplify and refactor program notifications * Use channel names in config, not IDs * Simplify notification logic
* Config: Require file path explicitly * run-bot: Expect config file path as --config-file or CONFIG_FILE * README: Update * uv: Remove python-dotenv and certifi dependencies * Move config files to repo root * Docker: Expect CONFIG_FILE * Compose: Specify config file and .secrets
Model all configuration as cog-specific pydantic.BaseModels.
Remove certifi, yarl and arrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Fixes #118
Drop ansible, yarl, arrow, certifi
We don't use any of these packages. Ansible is used during deployment, but it is installed during the GitHub Action execution.
Drop
python-dotenvThe program now expects the environment variables
DISCORD_BOT_TOKENandPRETIX_TOKENwithout falling back to.secrets.compose.ymlnow usessecretsasenv-fileinstead of binding the file into the container.Split configuration, use pydantic
Every cog (besides
Ping) now has its own configuration class. Configuration is modelled usingpydantic.BaseModel.Refactor
$participantscommand cogPing) instead of multi-file extension.Use channel names instead of IDs in config, simplify registration and program notification code
The configuration is now server-agnostic, and the code contains less indirection.