Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection of cellId in the LPD1M object #100

Open
camilabc23 opened this issue Nov 8, 2020 · 6 comments
Open

selection of cellId in the LPD1M object #100

camilabc23 opened this issue Nov 8, 2020 · 6 comments

Comments

@camilabc23
Copy link

The LPD1M object is giving us train ids and pulse ids but it would be essential that we also get the cell Ids, since all the analysis fails when using veto patterns on the LDP otherwise, since the memory cell allocation is not equivalent to the pulse ids.

@takluyver
Copy link
Member

Would it be useful to have an option to get the data back with cell IDs in the index instead of pulse IDs? We can do that quite easily.

You can already get the cell IDs with lpd.get_array('image.cellId'), though this will give you cell IDs for each module (i.e. 16 IDs per frame), whereas the index logic checks that they're all the same and gives you a single cell ID per frame.

@takluyver
Copy link
Member

PR #101 would add an option to get data with cell IDs in the index instead of pulse IDs. Please take a look and let me know if that would be useful to you. :)

@camilabc23
Copy link
Author

camilabc23 commented Nov 9, 2020 via email

@takluyver
Copy link
Member

This would be more 'instead' rather than 'in addition'. It would let you choose whether the data is labelled with pulse IDs or cell IDs, but there still wouldn't be an easy way to get both. Is that still useful?

@camilabc23
Copy link
Author

camilabc23 commented Nov 9, 2020 via email

@takluyver
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants