Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1491 [RiskAssessmentDocument] add: riskassessmentdocument generation information modal #3962

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

#1491 [RiskAssessmentDocument] add: riskassessmentdocument generation information modal #3962

wants to merge 6 commits into from
+600 −430

Conversation

theodaviddd
Copy link

No description provided.

@theodaviddd theodaviddd force-pushed the add_riskassessmentdocument_generation_information_modal branch 2 times, most recently from 8694685 to c2e6819 Compare June 8, 2024 16:32
@theodaviddd theodaviddd changed the title add: riskassessmentdocument generation information modal #1491 [RiskAssessmentDocument] add: riskassessmentdocument generation information modal Jun 8, 2024
@theodaviddd theodaviddd force-pushed the add_riskassessmentdocument_generation_information_modal branch from 5a35fe2 to 7a1d949 Compare June 8, 2024 16:44
@evarisk-micka evarisk-micka linked an issue Jun 12, 2024 that may be closed by this pull request
Génération du Document Unique - Fichier Zip lors de mauvaise connection ou de connection intérompues #3358
Open
4 tasks
evarisk-micka
evarisk-micka requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@evarisk-micka evarisk-micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le fonctionnel est chouette mais si on a trop de GP/UT, le chargement dépasse de la modal et on ne voit pas les gp/ut générés à la suite
Aussi tout le fichier digiriskstandard_riskassessment a été reformaté

@evarisk-micka evarisk-micka added Amélioration Minor feature 3 JS Javascript 5 and removed 3 labels Jun 12, 2024
@theodaviddd
Copy link
Author

Le fonctionnel est chouette mais si on a trop de GP/UT, le chargement dépasse de la modal et on ne voit pas les gp/ut générés à la suite Aussi tout le fichier digiriskstandard_riskassessment a été reformaté

Effectivement, je vais faire le changement pour gérer le cas où il y a beaucoup de GP/UT
Pour la deuxième remarque, normalement ça devrait régler le problème :
image

@theodaviddd theodaviddd force-pushed the add_riskassessmentdocument_generation_information_modal branch from 694955f to 9d46ad3 Compare June 13, 2024 14:37
@evarisk-micka
Copy link
Contributor

Sinon le reste est cool j'aime bien cette nouvelle fonctionnalité !

@theodaviddd
Copy link
Author

j'aime bien aussi! @evarisk-micka

@evarisk-micka evarisk-micka force-pushed the add_riskassessmentdocument_generation_information_modal branch from 1bf2158 to 0dbbc11 Compare August 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evarisk-micka evarisk-micka evarisk-micka approved these changes

Assignees

@theodaviddd theodaviddd

Labels
5 Amélioration Minor feature JS Javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Génération du Document Unique - Fichier Zip lors de mauvaise connection ou de connection intérompues
2 participants
@theodaviddd @evarisk-micka