chore: update model due to incompatibility with new text processing #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanise
reviewed
Feb 13, 2025
| @@ -127,6 +128,11 @@ def check_and_upgrade_checkpoint(self, checkpoint): | |||
| # Upgrading from 0.0 to 1.0 requires no changes; future versions might require changes | |||
| checkpoint["model_info"]["version"] = "1.0" | |||
|
|
|||
| # We changed the handling of phonological features in everyvoice==0.3.0 | |||
| if ckpt_version < Version("1.1"): | |||
| raise ValueError(f"""There were breaking changes to the handling of text in version 1.1, introduced in version 0.3.0 of EveryVoice. | |||
There was a problem hiding this comment.
Just "version 1.1" like this is confusing, because various things have versions in this message. Name it: "in dfagliner model version 1.1" or whatever strings accurately describes this.
| # We changed the handling of phonological features in everyvoice==0.3.0 | ||
| if ckpt_version < Version("1.1"): | ||
| raise ValueError(f"""There were breaking changes to the handling of text in version 1.1, introduced in version 0.3.0 of EveryVoice. | ||
| Your model is version {ckpt_version} and your model will not work as a result. Please downgrade to everyvoice 0.2.0.""") |
There was a problem hiding this comment.
0.2.0 never existed. You mean 0.2.0a1. Unless we publish 0.2.0==0.2.0a1, trying pip install everyvoice==0.2.0 will fail. Currently, even pip install everyvoice fails. And pip install everyvoice<0.3 will continue to fail, only with an explicit pip install everyvoice==0.2.0a1 will pip ever accept to install an alpha or beta version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see EveryVoiceTTS/EveryVoice#627