Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust the wizard resume message for known compatibility #629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joanise
Copy link
Member

@joanise joanise commented Jan 30, 2025

PR Goal?

The warning about the resume file coming from a different version is too generic. We know 0.2.0 and 0.3.0 resume files are compatible, so adjust the warning to pay attention the which versions are compatible and not.

Feedback sought?

Are the two new messages clearer, and less likely to cause confusion?

Priority?

beta

Tests added?

yes

How to test?

Take an existing save wizard progress file, and edit line 2 to show version 0.3.0 (current), 0.2.0 (older and still compatible) or 0.1.0 (older, not compatible) and see no message, still compat message, or not compat message, respectively.

Confidence?

medium

Version change?

no

Related PRs?

none

Copy link

semanticdiff-com bot commented Jan 30, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/wizard/tour.py  40% smaller
  everyvoice/tests/test_wizard.py  6% smaller
  pyproject.toml Unsupported file format

@joanise joanise requested a review from SamuelLarkin January 30, 2025 18:49
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (9a210df) to head (905fffe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   76.34%   76.36%   +0.02%     
==========================================
  Files          47       47              
  Lines        3483     3487       +4     
  Branches      479      480       +1     
==========================================
+ Hits         2659     2663       +4     
  Misses        721      721              
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLI load time: 0:00.26
Pull Request HEAD: 905fffeb909ed62f1f096c5709638d79d1043ed3
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1064 |     107881 |     typer.main
import time:       286 |     127301 |   typer
import time:      7721 |     207247 | everyvoice.cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant