feat: adjust the wizard resume message for known compatibility #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 76.24% 76.31% +0.06%
==========================================
Files 47 47
Lines 3490 3500 +10
Branches 481 484 +3
==========================================
+ Hits 2661 2671 +10
Misses 726 726
Partials 103 103 ☔ View full report in Codecov by Sentry. |
|
joanise
added a commit
that referenced
this pull request
Feb 11, 2025
cases handled: - recent versions that are known to be compatible - older version - back from the future - wrong software name
joanise
force-pushed
the
dev.ej/wizard-resume-compat
branch
from
c05e290 to
d2781b2
Compare
cases handled: - recent versions that are known to be compatible - older version - back from the future - wrong software name
From CI:
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses
deprecated stage names (commit, push) which will be removed in a future
version. Hint: often `pre-commit autoupdate --repo
https://github.com/pre-commit/pre-commit-hooks` will fix this. if it does
not -- consider reporting an issue to that repo.
So I ran
pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks
and that does seem to fix the issue since pre-commit-hooks 5.0.0 starts using
the non-deprecated stage names.
See https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0
joanise
force-pushed
the
dev.ej/wizard-resume-compat
branch
from
529e170 to
6c1f57f
Compare
joanise
added a commit
that referenced
this pull request
Feb 14, 2025
cases handled: - recent versions that are known to be compatible - older version - back from the future - wrong software name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
The warning about the resume file coming from a different version is too generic. We know 0.2.0 and 0.3.0 resume files are compatible, so adjust the warning to pay attention the which versions are compatible and not.
Feedback sought?
Are the two new messages clearer, and less likely to cause confusion?
Priority?
beta
Tests added?
yes
How to test?
Take an existing save wizard progress file, and edit line 2 to show version 0.3.0 (current), 0.2.0 (older and still compatible) or 0.1.0 (older, not compatible) and see no message, still compat message, or not compat message, respectively.
Confidence?
medium
Version change?
no
Related PRs?
none