Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only prepare the data once #82

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: only prepare the data once #82

merged 1 commit into from
Jun 19, 2024

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Jun 18, 2024

PR Goal?

This PR is required to fix EveryVoiceTTS/EveryVoice#419

Fixes?

Doesn't fix EveryVoiceTTS/EveryVoice#419 but is required

Feedback sought?

Ready to merge

Priority?

part of alpha, so may be medium-high

Tests added?

No, but may be I should add a small test in EV.

How to test?

for max_epochs in 3 6 9 12 15; do
   echo "Training up to $max_epochs"
   srun everyvoice train text-to-spec \
      config/everyvoice-text-to-spec.yaml \
      --config-args training.finetune_checkpoint=$PWD/logs_and_checkpoints/FeaturePredictionExperiment/base/checkpoints/last.ckpt \
      --config-args training.max_epochs=$max_epochs
done

Confidence?

Good

Version change?

No

Related PRs?

EveryVoiceTTS/EveryVoice#473

@SamuelLarkin SamuelLarkin merged commit b6e373d into main Jun 19, 2024
@SamuelLarkin SamuelLarkin deleted the dev.sl/419_resume branch June 19, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming training seems unstable
2 participants