Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dijkstra code and add tests #21

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Simplify dijkstra code and add tests #21

merged 11 commits into from
Feb 27, 2024

Conversation

dramanica
Copy link
Member

@dramanica dramanica commented Feb 27, 2024

Fix #19

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.51%. Comparing base (d0ac91d) to head (04dbe1e).
Report is 3 commits behind head on dev.

Files Patch % Lines
R/connectivity.R 75.00% 1 Missing ⚠️
R/dijkstra.R 85.71% 1 Missing ⚠️
R/hasCosts.R 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #21      +/-   ##
==========================================
+ Coverage   65.43%   69.51%   +4.07%     
==========================================
  Files          19       21       +2     
  Lines        1325     1335      +10     
==========================================
+ Hits          867      928      +61     
+ Misses        458      407      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dramanica dramanica merged commit 9e8078e into dev Feb 27, 2024
9 checks passed
@dramanica dramanica deleted the test_dijkstra_from branch February 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants