Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read q matrices #55

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Read q matrices #55

merged 8 commits into from
Oct 17, 2024

Conversation

eviecarter33
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 67.60563% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@54106aa). Learn more about missing BASE report.
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
R/q_matrix.R 66.66% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage        ?   81.84%           
=======================================
  Files           ?       85           
  Lines           ?     3234           
  Branches        ?        0           
=======================================
  Hits            ?     2647           
  Misses          ?      587           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dramanica
Copy link
Member

This looks really good! There is a lot of code that is not unit tested; tt would be good to add some tests before we merge in.

@dramanica dramanica merged commit 7e708c0 into main Oct 17, 2024
8 checks passed
@dramanica dramanica deleted the read_q_matrices branch October 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants