Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Shallow copy issue #231

Merged
merged 4 commits into from
Sep 6, 2024
Merged

[fix] Shallow copy issue #231

merged 4 commits into from
Sep 6, 2024

Conversation

pufanyi
Copy link
Collaborator

@pufanyi pufanyi commented Sep 6, 2024 •
edited
Loading

  1. Fix the shallow copy issue by force to deep copy every single gen_kwargs variables [BUG]: gen_kwargs in requests are shallow copy? #224
  2. Fix a small bug in Seed Bench

@pufanyi pufanyi requested a review from Luodian September 6, 2024 09:47
@Luodian Luodian merged commit 35d221f into main Sep 6, 2024
2 checks passed
@pufanyi pufanyi mentioned this pull request Sep 6, 2024
Closed
@pufanyi pufanyi deleted the pufanyi/gen_kwargs_fix branch September 10, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luodian Luodian Luodian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pufanyi @Luodian