-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Update utils.py #249
Conversation
correct video path in videomme_dic_to_text+subtitle
Hi @YangYangGirl , may I ask why would this additional hardcoded data path need to be added in the doc to visual function? I think current main branch should works well. If that is your default path in your own settings, maybe this change should be add into your own forked repo? If that is the case, I will close the PR. |
I think this problem has been fixed in commit Fix videomme evaluation? Current main branch seems already contains the path to data folder lmms-eval/lmms_eval/tasks/videomme/utils.py Lines 176 to 188 in bfff5ab
Seems like a duplicate fix. If this is the case, I will close this PR. |
Thanks for the kind reply. But I checked again, in
|
Yeah @YangYangGirl , I see your point. You are correct. I think this is some version problem as we change the logic and default folder for unzipping files. I revise a little bit to make it not absolute path. I think current version should be correct? |
correct video path in videomme_dic_to_text+subtitle