[Feat][Task] Add multi-round evaluation in llava-onevision; Add MMSearch Benchmark #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM!
The evaluation result for llava onevision has been aligned to the paper right?
I feel this could be our new feat and for others that want to add try and search feature should follow the same format of the doc_to_text in this PR and this PR should be the example PR.
|
Hi, thanks for the comments. I have just discovered some problems when conducting multi-gpu inference. I am trying to fix them. Please do not merge now. |
Update README.md about multi-round interaction.
KairuiHu
pushed a commit
that referenced
this pull request
Oct 24, 2024
…rch Benchmark (#277) * Add MMSearch. Add generate_until_multi_round function in LLaVA-OneVision * Fix linting error * Update mutli-gpu end2end inference support. Update README.md about multi-round interaction. * Fix linting error * Fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-round evaluation by adding a function
generate_until_multi_roundin llava-onevision;Add MMSearch Benchmark