-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Llava-SGlang #54
Merged
Merged
add Llava-SGlang #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! This is a great feature enabling inference for larger models. However, can you put a result screenshot or do more test to see if the results could match? |
Hi @jzhang38 🦦 |
1.5 7B: - model: llava_sglang
model_args: pretrained=liuhaotian/llava-v1.5-7b
tasks: mme,ai2d,scienceqa_img
batch_size: 1
log_samples: true
log_samples_suffix: eval_mme
output_path: "./logs/"
Match pretty closely |
1.5 13B: - model: llava_sglang
model_args: pretrained=liuhaotian/llava-v1.5-13b
tasks: mme,ai2d,scienceqa_img
batch_size: 1
log_samples: true
log_samples_suffix: eval_mme
output_path: "./logs/"
|
Luodian
added a commit
that referenced
this pull request
Apr 16, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
Luodian
added a commit
that referenced
this pull request
Apr 16, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
Luodian
approved these changes
Apr 18, 2024
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
* [Fix] rearrange location of init eval_logger * Ignore DeprecationWarnings in lmms_eval/__main__.py and lmms_eval/models/fuyu.py * Update lmms_eval/__main__.py and lmms_eval/utils.py * update * Update llava.py with LLaVA model imports and error handling * Add and test new datasets * update * Update wandb version and require report-editing:v0 * Add support for logging samples to Weights and Biases This commit adds a new command-line argument `--wandb_log_samples` to enable logging all model outputs and documents for per-sample measurement and post-hoc analysis to Weights and Biases. The `cli_evaluate` function has been modified to handle this new argument and log the samples if the argument is set to True. The `wandb_logger` object has also been updated to include a new method `log_eval_samples` for logging the samples. This enhancement improves the functionality of the LMMS evaluation tool. * update
kangreen0210
pushed a commit
to kangreen0210/LIME
that referenced
this pull request
Oct 6, 2024
…a_sglang add Llava-SGlang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add llava_sglang.
Some caveats:
example eval config and script: