Skip to content

Commit

Permalink
edit print at end of process and revert changes from last commit
Browse files Browse the repository at this point in the history
  • Loading branch information
gilax committed Aug 19, 2018
1 parent 79d3e2e commit 1a4d7cd
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 10 deletions.
2 changes: 1 addition & 1 deletion gulp/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ var SERVERS = {
* var PROXY_SERVER = 'http://abc-primo.hosted.exlibrisgroup.com'
* var PROXY_SERVER = 'https://abc-primo.hosted.exlibrisgroup.com:443'
*/
var PROXY_SERVER = 'https://sqa-na04.alma.exlibrisgroup.com';
var PROXY_SERVER = 'http://your-server:your-port';


let buildParams = {
Expand Down
19 changes: 10 additions & 9 deletions gulp/tasks/prepareAddon.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const prompt = require('prompt');
const camelCase = require('camel-case');
const streamToPromise = require('stream-to-promise');
const colors = require('colors/safe');
const path = require('path');


let buildParams = config.buildParams;
Expand Down Expand Up @@ -42,7 +43,6 @@ gulp.task('prepare-addon', ['select-view', 'custom-js','custom-scss','custom-css
.then(makeDirectory, handleError)
.then(copyFiles, handleError)
.then(compileAddon, handleError)
.then(announceFinishedCompiling, handleError)
.then(createDescriptorJson, handleError)
.then(announceFinishedProcess, handleError);

Expand Down Expand Up @@ -173,13 +173,6 @@ gulp.task('prepare-addon', ['select-view', 'custom-js','custom-scss','custom-css
}


function announceFinishedCompiling() {
console.log('\n');
console.log('Finished compiling addon\n');
console.log(colors.green('Addon can be found at /addons/' + npmId + '\n'));
}


function createDescriptorJson() {
return new Promise((resolve, reject) => {
let npmignorePath = directoryName + '/.npmignore';
Expand Down Expand Up @@ -280,7 +273,15 @@ gulp.task('prepare-addon', ['select-view', 'custom-js','custom-scss','custom-css

function announceFinishedProcess() {
console.log('\n');
console.log(colors.green("Please update 'descriptor.json' file with the fields at https://github.com/primousers/primostudio and publish to NPM\n"));
process.stdout.write('Finished compiling addon\n');
console.log('');
process.stdout.write(colors.green('Addon can be found at ' ));
process.stdout.write(colors.cyan(path.resolve('./addons/' + npmId)));
process.stdout.write(colors.green('.\nIn order to publish to NPM: Navigate to the addon folder. Review the \'package.json\' file. Then run \'npm publish\'.\n'));
process.stdout.write(colors.green('A basic descriptor for your addon was created in the file \'descriptor.json\'. Please review it and edit fields accordingly.\n'));
process.stdout.write(colors.green('When you are ready to publish to Primo-Studio, create a pull request at '));
process.stdout.write(colors.cyan('https://github.com/primousers/primostudio/tree/submit_here'));
process.stdout.write(colors.green(' appending your descriptor to the \'features.json\' file.\n'));
}


Expand Down
4 changes: 4 additions & 0 deletions node_modules/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1a4d7cd

Please sign in to comment.