Allows css|html|img|js subdirectories to be gitignore excluded #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that original author who changed the .gitignore files (see PR #106 ) expected the .gitignore within the 'custom' directory to override that of the project's root and so un-gitignore the css, html, img and js sub-directories. However, this would never have been possible because if you .gitignore an entire directory, then you cannot use ! to un-gitignore it futher down. This PR fixes that. See https://git-scm.com/docs/gitignore.
PS I'm raising this PR from my personal Github account but I have also made this .gitignore change in the britishlibrary fork of your ExLibris/primo-explore-devenv as I work there.