Revert "expand on the getContext() description"
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hategan
approved these changes
Apr 17, 2021
specification.md
Outdated
| @@ -166,7 +162,7 @@ using either a remote or local job management library; application jobs | |||
| are then submitted to the pilot system, which sends them directly to the | |||
| existing pilot job instances for execution, bypassing queuing | |||
| systems/LRMs. The requirements for the APIs used to submit the pilot jobs | |||
| as well as those used to run the application and remote job management | |||
| as well as those used to run the application l and remote job management | |||
There was a problem hiding this comment.
Well, the revert also covers some small bug fixes :-/
There was a problem hiding this comment.
Hah, OK. I think we can safely keep this fix though.
hategan
reviewed
Apr 17, 2021
specification.md
Outdated
| @@ -278,7 +274,7 @@ customary in the language in which the library is implemented | |||
|
|
|||
| #### Interaction with LRMs and Scalability | |||
|
|
|||
| Implementations should use bulk status operations when interacting with | |||
| Implementations must use bulk status operations when interacting with | |||
There was a problem hiding this comment.
Are we sure we want "must" instead of "should" here>
There was a problem hiding this comment.
I am very much in favor of should - thus the original edit. I'll do a separate PR for that one if that's ok for you...
There was a problem hiding this comment.
A separate PR sounds like a lot of work. I'm fine with this being kept here.
andre-merzky
force-pushed
the
revert-122-fix/get_context
branch
from
752d29c to
33a5ffa
Compare
andre-merzky
added a commit
that referenced
this pull request
Apr 17, 2021
as discussed in #125, this changes `must communicate in bulk` to `should...` - not all backends support bulks, `local` being a prominent example. The commit also fixes a stray `l`.
andre-merzky
added a commit
that referenced
this pull request
Apr 18, 2021
As discussed in #125, this changes `must communicate in bulk` to `should...`, Not all backends support bulks, `local` being a prominent example. The commit also fixes a stray `l`.
SteVwonder
reviewed
Apr 19, 2021
As discussed in #125, this changes `must communicate in bulk` to `should...`, Not all backends support bulks, `local` being a prominent example. The commit also fixes a stray `l`.
andre-merzky
force-pushed
the
revert-122-fix/get_context
branch
from
d0275a7 to
b39f557
Compare
|
Latest changes look nice. @SteVwonder? |
|
Yep! LGTM! Clicking the big green button :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122
See #122