Skip to content

BatchSchedulerExecutorConfig constructor propagates args incorrectly #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nkanazawa1989 opened this issue Apr 11, 2025 · 2 comments · Fixed by #515
Closed

BatchSchedulerExecutorConfig constructor propagates args incorrectly #514

nkanazawa1989 opened this issue Apr 11, 2025 · 2 comments · Fixed by #515

Comments

@nkanazawa1989
Copy link

BatchSchedulerExecutorConfig instantiates the superclass with args, but its order seems wrong.

psij-python/src/psij/executors/batch/batch_scheduler_executor.py

Line 108 in d49a2a4

super().__init__(work_directory, launcher_log_file)

psij-python/src/psij/job_executor_config.py

Lines 14 to 15 in d49a2a4

def __init__(self, launcher_log_file: Optional[Path] = None,
work_directory: Optional[Path] = None) -> None:

When both are specified, job scripts are created in unexpected folder and the launcher log may be dumped into a folder, which crashes the workflow.
@hategan hategan mentioned this issue Apr 11, 2025
Merged
@hategan
Copy link
Collaborator

hategan commented Apr 11, 2025

Thank you for finding this!
I submitted a PR (#515) to fix this.
Once it's merged, we will release a new version.

@hategan
Copy link
Collaborator

hategan commented Apr 14, 2025

Fix is in an 0.9.10 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed incorrect order of parameters in BatchSchedulerExecutorConfig ExaWorks/psij-python
2 participants
@hategan @nkanazawa1989