Skip to content

Fixed incorrect order of parameters in BatchSchedulerExecutorConfig #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fixed incorrect order of parameters in BatchSchedulerExecutorConfig #515

merged 1 commit into from
Apr 14, 2025

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Apr 11, 2025

Fixes #514

@hategan hategan requested a review from andre-merzky April 11, 2025 17:04
@hategan hategan mentioned this pull request Apr 11, 2025
Closed
andre-merzky
andre-merzky approved these changes Apr 12, 2025
View reviewed changes
Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@hategan hategan merged commit 04b5641 into main Apr 14, 2025
14 checks passed
@hategan hategan deleted the fix_bsconfig_init branch April 14, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-merzky andre-merzky andre-merzky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchSchedulerExecutorConfig constructor propagates args incorrectly
2 participants
@hategan @andre-merzky