-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostlist #414
Conversation
…FILE, which contains a list of nodes allocated to the job.
into something that can be copied and pasted into a shell.
with older outputs.
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 73.65% 70.41% -3.25%
==========================================
Files 79 78 -1
Lines 3575 3437 -138
==========================================
- Hits 2633 2420 -213
- Misses 942 1017 +75
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! The format of all the node files is the same--a hostname on each line or something?
In theory, yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that one :-)
This makes (most) executors set a PSIJ_NODEFILE variable pointing to a nodefile, which is a solution for #200 and touches on ExaWorks/job-api-spec#148, although it would be good to figure out a way to formalize this in the spec.
It also contains a few other minor fixes.