-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File staging #450
Open
hategan
wants to merge
33
commits into
main
Choose a base branch
from
file_staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
File staging #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 74.69% 76.66% +1.97%
==========================================
Files 94 96 +2
Lines 3912 4440 +528
==========================================
+ Hits 2922 3404 +482
- Misses 990 1036 +46 ☔ View full report in Codecov by Sentry. |
deadlocks and similar.
…eled jobs and spam the pytest suite, since pytest doesn't capture the log after the test is done.
special devices which bash will happily emulate if not found.
Since the addition of staging, errors can reasonably occur outside of the launcher as well as inside the launcher and pre- and post- launch scripts. So we treat the output of the whole script (including launcher) as potential indicator of an error.
…s to CWD (the CI runner runs things in /tmp).
…to avoid clashes with other things that might be defined in the environment. - use `StageOutFlags` to express when cleanup happens rather than a boolean flag - fixed equality operator in `JobSpec` - added `__str__`, `__eq__` and `__hash__` methods for staging objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds file staging to some executors (local and the batch family).