-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pa accordian #36
Pa accordian #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Pascal for all the effort you have put into this.
I do have some inline comments. Some are carried over from #24. My stance has not changed on those. Others are easy to fix and some are probably not as easy. One straightforward thing is that various OS special files and, in most cases, binary files (e.g., .DS_Store
) should not be in git.
I also mentioned in #24 why big PRs are problematic as well as the fact that we should discuss big changes with the team and community so that we increase the chances that the team and community at large can converge on a generally agreeable solution. That remains relevant.
8d21d1a
to
acdaf39
Compare
acdaf39
to
9965555
Compare
…moval of an unused class that seemed to be used for testing.
For the record, while updating the CSS, I ran into an issue in which the branch indicator divs were showing even when they were disabled. This occurred after switching views out and back into the calendar view. |
…cIndex testing columns
… mongodb database.
Addressed and fixed |
No description provided.