Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pa accordian #36

Merged
merged 19 commits into from
Feb 22, 2023
Merged

Pa accordian #36

merged 19 commits into from
Feb 22, 2023

Conversation

aschwanden1
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@hategan hategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pascal for all the effort you have put into this.

I do have some inline comments. Some are carried over from #24. My stance has not changed on those. Others are easy to fix and some are probably not as easy. One straightforward thing is that various OS special files and, in most cases, binary files (e.g., .DS_Store) should not be in git.

I also mentioned in #24 why big PRs are problematic as well as the fact that we should discuss big changes with the team and community so that we increase the chances that the team and community at large can converge on a generally agreeable solution. That remains relevant.

@hategan
Copy link
Collaborator

hategan commented Feb 14, 2023

For the record, while updating the CSS, I ran into an issue in which the branch indicator divs were showing even when they were disabled. This occurred after switching views out and back into the calendar view.

@aschwanden1
Copy link
Collaborator Author

For the record, while updating the CSS, I ran into an issue in which the branch indicator divs were showing even when they were disabled. This occurred after switching views out and back into the calendar view.

Addressed and fixed

@aschwanden1 aschwanden1 marked this pull request as ready for review February 18, 2023 00:09
@hategan hategan merged commit bc3d22a into main Feb 22, 2023
@hategan hategan deleted the pa-accordian branch May 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants