Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tolerance to boundary file write time check #1447

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Jan 15, 2025

Summary

Check for when boundary file writing begins only used a simple floating point comparison; this adds a tolerance

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number: #1444

@mbkuhn mbkuhn enabled auto-merge (squash) January 16, 2025 15:59
@mbkuhn mbkuhn merged commit 6583842 into Exawind:main Jan 16, 2025
15 checks passed
@mbkuhn mbkuhn deleted the abl_bndry_write_time_tol branch January 17, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants