Ocean Waves waves2amr bug fixes - levelset field and initial read #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zero fields during updates where updates will occur
mbkuhn
commented
Jan 17, 2025
| @@ -339,59 +339,51 @@ struct ReadInputsOp<W2AWaves> | |||
| std::to_string(flag)); | |||
| } | |||
|
|
|||
| // If init_wave_field is activated and initialization will be done, get | |||
| // modes on every processor | |||
| if (wdata.init_wave_field && data.sim().time().time_index() == 0) { | |||
There was a problem hiding this comment.
this looks like a lot of changes here, but really the only change within ReadInputsOp is removing this conditional. The first part needed to be remove to fix a segfault under certain conditions, and the second part did nothing because time_index always == 0 during the read inputs phase of the algorithm because the current time hasn't been calculated yet.
marchdf
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing 2 bugs. Because the w2a routines only update the ow fields where necessary, the values outside of these areas need to be reasonable. Setting levelset = 0 is bad because gradients can lead to intermediate vof values (between 0 and 1). Also, the modes still need to be read when the waves are not initialized over the entire domain.
Added a regression test that blows up without the first fix and segfaults without the second.
No diffs caused for the existing w2a reg tests because this fixes things that they did not cover.
Pull request type
Checklist
The following is included:
This PR was tested by running:
Additional background