Fix for debug build: Fix ill-formed KOKKOS macro function decoration. #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrood-nrel
reviewed
Oct 4, 2024
jrood-nrel
approved these changes
Oct 4, 2024
|
Closes #1302 |
|
This is great. Thanks James. |
|
@overfelt thank you for taking care of this! I would not have gotten there. My GPU dev box is down this week so hopefully I can test it next week. |
marchdf
approved these changes
Oct 4, 2024
|
It is crazy that on a debug build the function became a no-op. No warning, no error. It just did nothing. Stared at the code for quite a while before it jumped out at me the "KOKKOS_FUNCTION KOKKOS_FUNCTION" in the declaration. |
|
eagle eyes. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.