Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to "params" arguments in Excel formulas, for Registration #43

Closed
wants to merge 1 commit into from

Conversation

amibar
Copy link

@amibar amibar commented Jan 1, 2017

Hi,

I am using the params feature of the ExcelDna-Registration and I noticed that the IntelliSense doesn't support it.
The code I added deals with this, but with some limitations, see the comment I wrote in the code (BUGBUG).

I don't know if it's the most efficient way to write it, but it works.

Ami

@govert
Copy link
Member

govert commented Jan 1, 2017

@amibar Thank you for the contribution - I'm happy to have some better support for this.
I'll only be able to review and go through the details in two weeks time, though :-(

@govert
Copy link
Member

govert commented May 19, 2017

@amibar I'm sorry I have not yet had a look at this. I've spent the bit of time I had for this project on trying to fix the issues relating to Excel 2016. If this is fixed now, I can finally have a look at your changes.

@govert
Copy link
Member

govert commented Apr 29, 2018

@amibar OK - I finally got round to incorporating your request. It was easier for me to bring your code in directly and refactor as I went along than to merge the pull request. But you should see this feature in the IntelliSense version 1.0.7. It still doesn't deal with the case you pointed out where the location goes back to an earlier argument - it looked like a fairly big change to carry through, for not much benefit.

Thank you for your help, and please let me know if you see any issues with the implementation.

@govert govert closed this Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants