Do not throw from Win32Helper.GetFocusedWindowHandle() #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is called during initialization, from a background thread. An exception there will crash Excel if not handled. Note that there is at least one case where this happens : when Excel launches on a locked desktop (typically through a scheduled task). Since there are already some cases where this function will return IntPtr.Zero, it makes sense to default to this, rather than catch at the calling site.
|
Cool - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is called during initialization, from a background thread.
An exception there will crash Excel if not handled.
Note that there is at least one case where this happens :
when Excel launches on a locked desktop (typically through a scheduled task).
Since there are already some cases where this function will return IntPtr.Zero,
it makes sense to default to this, rather than catch at the calling site.