Update projects and NuGet packages to target Excel-DNA v1.0.0

[augustoproiete]

... as the title says

[govert]

So my thought would be - why? I guess in Registration that didn't occur because the version number was old there.
The reason, I guess, us to get the signed ExcelDna.Intrgration? If so, that's OK. But I would in future like to keep the releases of IntelliSense and the core add-in independent where it makes sense.

[govert]

IntelliSense has extra version stuff in the code (not from the assembly version) that ensures only one server is loaded in the process. We need to review that and update too.

[augustoproiete]

So my thought would be - why?

Main reason: If IntelliSense is being installed from an add-in (Integrated display server: ExcelDna.IntelliSense.dll library) my understanding is that they should both reference the same version of ExcelDna.Integration.dll.

If the above is true, then I'd expect an updated release of ExcelDna.IntelliSense every time a new ExcelDna.Integration gets released - side-by-side.

---

Once the signed version of ExcelDna.Integration is released as a nuget package, then we can update this again (future PR) to reference the new NuGet package (1.1.0) and then sign ExcelDna.IntelliSense in the process.

[augustoproiete]

IntelliSense has extra version stuff in the code (not from the assembly version) that ensures only one server is loaded in the process. We need to review that and update too.

Really? Where is that? I don't see any hard-coded version number of anything like that. I also looked at commit 994749a where you bumped the version from 1.0.9 to 1.1.0 and didn't see anything special other than updating the assembly version and nuspec.

[govert]

My understanding is that a new add-in (v1.0.0) can use the current IntelliSense (built targeting older Integration) without problems. Am I wrong? I can't check now.

Version stuff is in IntelliSenseServer.

[govert]

Last update didn't change the binaries, I think.

[augustoproiete]

My understanding is that a new add-in (v1.0.0) can use the current IntelliSense (built targeting older Integration) without problems. Am I wrong? I can't check now.

Yes it works today, as long as the latest version is loaded first in the AppDomain (which is usually the case in the happy path), although it doesn't hurt to reference the updated one.

Having said that, once we release the signed version of ExcelDna.Integration (1.1.0), then we do need re-target ExcelDna.IntelliSense to reference & depend on that version. After that, it's back to normal and we can choose not to keep it in sync (as it is today).

[augustoproiete]

Version stuff is in IntelliSenseServer.

Thanks. I found it and updated the PR to bump it.

[govert]

Why so high? Maybe 1.1.0 for the next version (and 1.1.1 etc. for small updates during the 1.1.0 ExcelDna.Integration life?)

[govert]

I'm not sure the ServerVersion and the AssemblyVersion can be kept in sync in the strong-name world? Then we might as well keep the assembly version fixed at 1.1? (or 1.1.1). I'm getting confused...

[augustoproiete]

Why so high? Maybe 1.1.0 for the next version (and 1.1.1 etc. for small updates during the 1.1.0 ExcelDna.Integration life?)

AssemblyVersion is 1.1.0 already. It seems this ServerVersion variable went out of sync with the AssemblyVersion. So in this PR I'm bumping the AssemblyVersion to 1.2.0 and keeping ServerVersion in sync...

[augustoproiete]

I'm not sure the ServerVersion and the AssemblyVersion can be kept in sync in the strong-name world? Then we might as well keep the assembly version fixed at 1.1? (or 1.1.1). I'm getting confused...

I'd suggest we sync ServerVersion with AssemblyInformationalVersion (which is what gets translated to ProductVersion at the end.

The reason being that any modern build servers (such as Azure Pipelines) supports updating the AssemblyInformationalVersion during build and baking it into the compiled assembly... And to make ServerVersion get bumped it would take some scripting.

If I understand correctly, ServerVersion is just a custom metadata that is used to determine the highest version of the IntelliSense from all the available IntelliSense servers across all add-ins, so the number doesn't really matter much, as long as it's always higher than the previous release.