Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high-priority UI fixes #111

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

high-priority UI fixes #111

wants to merge 8 commits into from

Conversation

jenny-s51
Copy link
Contributor

  • UI fix for password complexity popup
  • complexity standards are now stated in alert message

@jenny-s51
Copy link
Contributor Author

  • also fixes grammar on "sign up" page/buttons

@jenny-s51
Copy link
Contributor Author

  • fixed issue of "insufficient scope" when editing user as root
  • edits to users can now be made from the root account

@jenny-s51 jenny-s51 changed the title complexity popup -- adds password standards to alert msg high-priority UI fixes Nov 22, 2018
shreyapandit
shreyapandit requested changes Nov 27, 2018
View reviewed changes
Copy link
Collaborator

@shreyapandit shreyapandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jenny, this looks good overall. Could you also add the fix to the create user page where it falsely states that passwords don't match and allows you to go through?

@jenny-s51
Copy link
Contributor Author

  • "passwords don't match" error resolved
  • password complexity standards are now static on sign-up/create-user pgs.

@jenny-s51
Copy link
Contributor Author

password complexity requirements now stated on top of "create user" and "sign up" pgs.

@shreyapandit
Copy link
Collaborator

Hi @jenny-s51 , thaks for your work on this.
I just checked out your branch locally and the Edit User as root issue still persists. Please check screenshot attached.
screen shot 2018-12-06 at 2 32 35 pm

@jenny-s51
can now edit root
a9751de
@jenny-s51
Merge remote-tracking branch 'origin/jenny_UI-fixes' into fixed_editu…
4dd1848 
…serasroot

* origin/jenny_UI-fixes:
  password standards now static on top of "sign up" and "create user" pgs.
  password complexity requirements now stated @ top of "create user" pg.
@jenny-s51
fixed error
242b168
@jenny-s51
Copy link
Contributor Author

  • edits to root account info are now successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyapandit shreyapandit shreyapandit requested changes

@saurabh21289 saurabh21289 saurabh21289 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenny-s51 @shreyapandit @saurabh21289