Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan classpaths for extensions only once #109

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

bszeman9
Copy link
Contributor

@bszeman9 bszeman9 commented Sep 18, 2021

See details in #98

Summary

Scan classpaths for extensions only once not per test suite class.

Additional Details

#98

Checklist

Testing

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have manually verified that my code changes do the right thing.
  • I have run the tests and verified that my changes do not introduce any regressions.
  • I have written unit tests to verify that my code changes do the right thing and to protect my code against regressions

Documentation

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have updated the "Unreleased" section of CHANGELOG.md with a brief description of my changes.
  • I have updated code comments - both GroovyDoc/JavaDoc-style comments and inline comments - where appropriate.
  • I have read CONTRIBUTING.md and have followed its guidance.

@deblaci
Copy link

deblaci commented Sep 18, 2021

Well done Bence, I can't wait for try it. :)

@dpalfi
Copy link

dpalfi commented Sep 18, 2021

1 if and it's a lot faster, GJ

@awittha awittha self-requested a review November 29, 2021 19:33
@awittha awittha self-assigned this Nov 29, 2021
@awittha awittha added the enhancement New feature or request label Nov 29, 2021
Copy link
Contributor

@awittha awittha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@awittha awittha merged commit 3893489 into ExpediaGroup:master Nov 29, 2021
@rh-hemartin
Copy link

Hey! Any chance of this being released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants