-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #37969 from ArekChr/feat/edit_category
feat: rename category
- Loading branch information
Showing
20 changed files
with
275 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/libs/API/parameters/RenameWorkspaceCategoriesParams.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| type RenameWorkspaceCategoriesParams = { | ||
| policyID: string; | ||
| /** | ||
| * Stringified JSON object with type of following structure: | ||
| * {[oldName: string]: string;} where value is new category name | ||
| */ | ||
| categories: string; | ||
| }; | ||
|
|
||
| export default RenameWorkspaceCategoriesParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import React, {useCallback} from 'react'; | ||
| import {Keyboard} from 'react-native'; | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import FormProvider from '@components/Form/FormProvider'; | ||
| import InputWrapper from '@components/Form/InputWrapper'; | ||
| import type {FormInputErrors, FormOnyxValues} from '@components/Form/types'; | ||
| import TextInput from '@components/TextInput'; | ||
| import useAutoFocusInput from '@hooks/useAutoFocusInput'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import * as ErrorUtils from '@libs/ErrorUtils'; | ||
| import Navigation from '@libs/Navigation/Navigation'; | ||
| import * as ValidationUtils from '@libs/ValidationUtils'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import INPUT_IDS from '@src/types/form/WorkspaceCategoryForm'; | ||
| import type {PolicyCategories} from '@src/types/onyx'; | ||
|
|
||
| type CategoryFormProps = { | ||
| /** All policy categories */ | ||
| policyCategories: OnyxEntry<PolicyCategories>; | ||
|
|
||
| /** The name of the category */ | ||
| categoryName?: string; | ||
|
|
||
| /** Function to call when the form is submitted */ | ||
| onSubmit: (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => void; | ||
| }; | ||
|
|
||
| function CategoryForm({onSubmit, policyCategories, categoryName}: CategoryFormProps) { | ||
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
| const {inputCallbackRef} = useAutoFocusInput(); | ||
|
|
||
| const validate = useCallback( | ||
| (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => { | ||
| const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM> = {}; | ||
| const newCategoryName = values.categoryName.trim(); | ||
|
|
||
| if (!ValidationUtils.isRequiredFulfilled(newCategoryName)) { | ||
| errors.categoryName = 'workspace.categories.categoryRequiredError'; | ||
| } else if (policyCategories?.[newCategoryName]) { | ||
| errors.categoryName = 'workspace.categories.existingCategoryError'; | ||
| } else if (newCategoryName === CONST.INVALID_CATEGORY_NAME) { | ||
| errors.categoryName = 'workspace.categories.invalidCategoryName'; | ||
| } else if ([...newCategoryName].length > CONST.CATEGORY_NAME_LIMIT) { | ||
| // Uses the spread syntax to count the number of Unicode code points instead of the number of UTF-16 code units. | ||
| ErrorUtils.addErrorMessage(errors, 'categoryName', ['common.error.characterLimitExceedCounter', {length: [...newCategoryName].length, limit: CONST.CATEGORY_NAME_LIMIT}]); | ||
| } | ||
|
|
||
| return errors; | ||
| }, | ||
| [policyCategories], | ||
| ); | ||
|
|
||
| const submit = useCallback( | ||
| (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => { | ||
| onSubmit(values); | ||
| Keyboard.dismiss(); | ||
| Navigation.dismissModal(); | ||
| }, | ||
| [onSubmit], | ||
| ); | ||
|
|
||
| return ( | ||
| <FormProvider | ||
| formID={ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM} | ||
| onSubmit={submit} | ||
| submitButtonText={translate('common.save')} | ||
| validate={validate} | ||
| style={[styles.mh5, styles.flex1]} | ||
| enabledWhenOffline | ||
| > | ||
| <InputWrapper | ||
| ref={inputCallbackRef} | ||
| InputComponent={TextInput} | ||
| maxLength={CONST.CATEGORY_NAME_LIMIT} | ||
| defaultValue={categoryName} | ||
| label={translate('common.name')} | ||
| accessibilityLabel={translate('common.name')} | ||
| inputID={INPUT_IDS.CATEGORY_NAME} | ||
| role={CONST.ROLE.PRESENTATION} | ||
| autoFocus | ||
| /> | ||
| </FormProvider> | ||
| ); | ||
| } | ||
|
|
||
| CategoryForm.displayName = 'CategoryForm'; | ||
|
|
||
| export default CategoryForm; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.