Skip to content

Commit

Permalink
Merge branch 'main' into @kosmydel/lottie-react-native-web-support
Browse files Browse the repository at this point in the history
  • Loading branch information
kosmydel committed Nov 7, 2023
2 parents c2cbc47 + da2c79e commit 01c4add
Show file tree
Hide file tree
Showing 180 changed files with 3,932 additions and 1,150 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/cherryPick.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
token: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Set up git for OSBotify
id: setupGitForOSBotify
uses: Expensify/App/.github/actions/composite/setupGitForOSBotifyApp@8c19d6da4a3d7ce3b15c9cd89a802187d208ecab
with:
GPG_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}
Expand Down Expand Up @@ -119,7 +120,7 @@ jobs:
**Important:** There may be conflicts that GitHub is not able to detect, so please _carefully_ review this pull request before approving."
gh pr edit --add-assignee "${{ github.actor }},${{ steps.getCPMergeCommit.outputs.MERGE_ACTOR }}"
env:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}

- name: "Announces a CP failure in the #announce Slack room"
uses: 8398a7/action-slack@v3
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/finishReleaseCycle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ jobs:
echo "IS_DEPLOYER=false" >> "$GITHUB_OUTPUT"
fi
env:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}

- name: Reopen and comment on issue (not a team member)
if: ${{ !fromJSON(steps.isDeployer.outputs.IS_DEPLOYER) }}
uses: Expensify/App/.github/actions/javascript/reopenIssueWithComment@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}
ISSUE_NUMBER: ${{ github.event.issue.number }}
COMMENT: |
Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Expand All @@ -51,14 +51,14 @@ jobs:
id: checkDeployBlockers
uses: Expensify/App/.github/actions/javascript/checkDeployBlockers@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}
ISSUE_NUMBER: ${{ github.event.issue.number }}

- name: Reopen and comment on issue (has blockers)
if: ${{ fromJSON(steps.isDeployer.outputs.IS_DEPLOYER) && fromJSON(steps.checkDeployBlockers.outputs.HAS_DEPLOY_BLOCKERS || 'false') }}
uses: Expensify/App/.github/actions/javascript/reopenIssueWithComment@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}
ISSUE_NUMBER: ${{ github.event.issue.number }}
COMMENT: |
This issue either has unchecked items or has not yet been marked with the `:shipit:` emoji of approval.
Expand Down
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001039505
versionName "1.3.95-5"
versionCode 1001039600
versionName "1.3.96-0"
}

flavorDimensions "default"
Expand Down
2 changes: 1 addition & 1 deletion contributingGuides/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Additionally if you want to discuss an idea with the open source community witho
- If you have made a change to your pull request and are ready for another review, leave a comment that says "Updated" on the pull request itself.
- Please keep the conversation in GitHub, and do not ping individual reviewers in Slack or Upwork to get their attention.
- Pull Request reviews can sometimes take a few days. If your pull request has not been addressed after four days please let us know via the #expensify-open-source Slack channel.
- On occasion, our engineers will need to focus on a feature release and choose to place a hold on the review of your PR. Depending on the hold length, our team will decide if a bonus will be applied to the job.
- On occasion, our engineers will need to focus on a feature release and choose to place a hold on the review of your PR.
#### Important note about JavaScript Style
- Read our official [JavaScript and React style guide](https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md). Please refer to our Style Guide before asking for a review.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
title: Personal Cards
description: Connect your credit card directly to Expensify to easily track your personal finances.
---
## Resource Coming Soon!

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,73 @@
---
title: The Expenses Page
description: The Expenses Page
description: Details on Expenses Page filters
---
## Resource Coming Soon!
# Overview

The Expenses page allows you to see all of your personal expenses. If you are an admin, you can view all submitter’s expenses on the Expensify page. The Expenses page can be filtered in several ways to give you spending visibility, find expenses to submit and export to a spreadsheet (CSV).

## Expense filters
Here are the available filters you can use on the Expenses Page:

- **Date Range:** Find expenses within a specific time frame.
- **Merchant Name:** Search for expenses from a particular merchant. (Partial search terms also work if you need clarification on the exact name match.)
- **Workspace:** Locate specific Group/Individual Workspace expenses.
- **Categories:** Group expenses by category or identify those without a category.
- **Tags:** Filter expenses with specific tags.
- **Submitters:** Narrow expenses by submitter (employee or vendor).
- **Personal Expenses:** Find all expenses yet to be included in a report. A Workspace admin can see these expenses once they are on a Processing, Approved, or Reimbursed report.
- **Open:** Display expenses on reports that still need to be submitted (not submitted).
- **Processing, Approved, Reimbursed:** See expenses on reports at various stages – processing, approved, or reimbursed.
- **Closed:** View expenses on closed reports (not submitted for approval).

Here's how to make the most of these filters:

1. Log into your web account
2. Go to the **Expenses** page
3. At the top of the page, click on **Show Filters**
4. Adjust the filters to match your specific needs

Note, you might notice that not all expense filters are always visible. They adapt based on the data you're currently filtering and persist from the last time you logged in. For instance, you won't see the deleted filter if there are no **Deleted** expenses to filter out.

If you are not seeing what you expected, you may have too many filters applied. Click **Reset** at the top to clear your filters.


# How to add an expense to a report from the Expenses Page
The submitter (and their copilot) can add expenses to a report from the Expenses page.

Note, when expenses aren’t on a report, they are **personal expenses**. So you’ll want to make sure you haven’t filtered out **personal expenses** expenses, or you won’t be able to see them.

1. Find the expense you want to add. (Hint: Use the filters to sort expenses by the desired date range if it is not a recent expense.)
2. Then, select the expense you want to add to a report. You can click Select All to select multiple expenses.
3. Click **Add to Report** in the upper right corner, and choose either an existing report or create a new one.

# How to code expenses from the Expenses Page
To code expenses from the Expenses page, do the following:

1. Look for the **Tag**, **Category**, and **Description** columns on the **Expenses** page.
2. Click on the relevant field for a specific expense and add or update the **Category**, **Tag**, or **Description**.

Note, you can also open up individual expenses by clicking on them to see a detailed look, but coding the expenses from the Expense list is even faster and more convenient!

# How to export expenses to a CSV file or spreadsheet
If you want to export multiple expenses, run through the below steps:
Select the expenses you want to export by checking the box to the left of each expense.
Then, click **Export To** in the upper right corner of the page, and choose our default CSV format or create your own custom CSV template.


# FAQ

## Can I use the filters and analytics features on the mobile app?
The various features on the Expenses Page are only available while logged into your web account.

## As a Workspace admin, what submitter expenses can you see?
A Workspace admin can see Processing, Approved, and Reimbursed expenses as long as they were submitted on the workspace that you are an admin.

If employees submit expense reports on a workspace where you are not an admin, you will not have visibility into those expenses. Additionally, if an expense is left unreported, a workspace admin will not be able to see that expense until it’s been added to a report.

A Workspace admin can edit the tags and categories on an expense, but if they want to edit the amount, date, or merchant name, the expense will need to be in a Processing state or rejected back to the submitter for changes.
We have more about company card expense reconciliation in this support article.

## Can I edit multiple expenses at once?
Yes! Select the expenses you want to edit and click **Edit Multiple**.

Original file line number Diff line number Diff line change
Expand Up @@ -5,40 +5,7 @@ description: Get the most out of your Expensify Card with exclusive perks!


# Overview
The Expensify Card is packed with perks, both native to our Card program and through exclusive discounts with partnering solutions. The Expensify Card’s primary perks include:
- Access to our premiere Expensify Lounge (with more locations coming soon)
- Swipe to Win, where every swipe has a chance to win fun personalized gifts for you and your closest friends and family members
- And unbeatable cash back incentive with each swipe
Below, we’ll cover all of our exclusive offers in more detail and how to claim discounts with our partners.

# Expensify Card Perks

## Access to the Expensify Lounge
Our [world-class lounge](https://use.expensify.com/lounge) is now open for Expensify members and guests to enjoy!

We invite you to visit our sleek San Francisco lounge, where sweeping city views provide the perfect backdrop for a morning coffee to start your day.

Enjoy complimentary cocktails and snacks in a vibrant atmosphere with blazing-fast WiFi. Whether you want a place to focus on work, socialize with other members, or simply kick back and relax – our lounge is ready and waiting to welcome you.

You can sign up for free [here](https://use.expensify.com) if you’re not an Expensify member. If you have any questions, reach out to [email protected] and [check this out](https://use.expensify.com/lounge) for more info.

## Swipe to Win
Swipe to Win is a new [Expensify Card](https://use.expensify.com/company-credit-card) perk that gives cardholders the chance to send a gift to a friend, family member, or essential worker on the frontlines!

Winners can choose to _Send a Smile_ or _Send a Laugh_. To start, we’re offering one gift per option:

- **Send A Smile:** Champagne by Expensify
- **Send a Laugh:** Jenga Set

**How to Participate**
It’s easy! Once you have an Expensify Card, you just need to start using it. With each swipe, you're automatically entered to win and have a 1 in 250 chance of getting a prize!

**How will I know if I’ve won?**
Winners will be notified immediately via the Expensify app, and receive additional instructions on how to choose and send their desired gift.

If you don't have Expensify notifications turned on yet, here are some helpful guides:
- [Apple Notification Preferences](https://support.apple.com/en-us/HT201925)
- [Android Notification Preferences](https://community.expensify.com/home/leaving?allowTrusted=1&target=https%3A%2F%2Fsupport.google.com%2Fandroid%2Fanswer%2F9079661%3Fhl%3Den)
The Expensify Card is packed with perks, both native to our Card program and through exclusive discounts with partnering solutions. Below, we’ll cover all of our exclusive offers in more detail and how to claim discounts with our partners.

# Partner Specific Perks

Expand Down Expand Up @@ -222,26 +189,3 @@ Stripe Atlas helps removes obstacles typically associated with starting a busine

**How to redeem:** Sign up with your Expensify Card.

# FAQ

## Where is the Expensify Lounge?
The Expensify Lounge is located on the 16th floor of 88 Kearny Street in San Francisco, California, 94108. This is currently our only lounge location, but keep an eye out for more work lounges popping up soon!

## When is the Expensify Lounge open?
The lounge is open 8 a.m. to 6 p.m. from Monday through Friday, except for national holidays. Capacity is limited, and we are admitting loungers on a first-come, first-served basis, so make sure to get there early!

## Who can use the lounge workplace?
Customers with an Expensify subscription can use Expensify’s lounge workplace, and any partner who has completed [ExpensifyApproved! University!](https://university.expensify.com/users/sign_in?next=%2Fdashboard)




# FAQ
This section covers the useful but not as vital information, it should capture commonly queried elements which do not organically form part of the About or How-to sections.

- What's idiosyncratic or potentially confusing about this feature?
- Is there anything unique about how this feature relates to billing/activity?
- If this feature is released, are there any common confusions that can't be solved by improvements to the product itself?
- Similarly, if this feature hasn't been released, can you predict and pre-empt any potential confusion?
- Is there any general troubleshooting for this feature?
- Note: troubleshooting should generally go in the FAQ, but if there is extensive troubleshooting, such as with integrations, that will be housed in a separate page, stored with and linked from the main page for that feature.

This file was deleted.

Loading

0 comments on commit 01c4add

Please sign in to comment.