code review updates

src/libs/localFileCreate/index.native.ts

@@ -1,13 +1,14 @@
 import RNFetchBlob from 'react-native-blob-util';
 import * as FileUtils from '@libs/fileDownload/FileUtils';
+import type LocalFileCreate from './types';
 
 /**
  * Creates a blob file using RN Fetch Blob
  * @param fileName name of the file
  * @param textContent content of the file
  * @returns path, filename and size of the newly created file
  */
-const localFileCreate = (fileName: string, textContent: string) => {
+const localFileCreate: LocalFileCreate = (fileName, textContent) => {
     const newFileName = FileUtils.appendTimeToFileName(fileName);
     const dir = RNFetchBlob.fs.dirs.DocumentDir;
     const path = `${dir}/${newFileName}.txt`;

src/libs/localFileCreate/index.ts

@@ -1,12 +1,13 @@
 import * as FileUtils from '@libs/fileDownload/FileUtils';
+import type LocalFileCreate from './types';
 
 /**
  * Creates a Blob file
  * @param fileName name of the file
  * @param textContent content of the file
  * @returns path, filename and size of the newly created file
  */
-const localFileCreate = (fileName: string, textContent: string) => {
+const localFileCreate: LocalFileCreate = (fileName, textContent) => {
     const newFileName = FileUtils.appendTimeToFileName(fileName);
     const blob = new Blob([textContent], {type: 'text/plain'});
     const url = URL.createObjectURL(blob);

src/libs/localFileCreate/types.ts

@@ -0,0 +1,3 @@
+type LocalFileCreate = (fileName: string, textContent: string) => Promise<{path: string; newFileName: string; size: number}>;
+
+export default LocalFileCreate;

src/libs/localFileDownload/index.ios.ts

@@ -1,6 +1,6 @@
 import {Share} from 'react-native';
 import RNFetchBlob from 'react-native-blob-util';
-import localFileCreate from '@libs/localFileCreate/index.native';
+import localFileCreate from '@libs/localFileCreate';
 import type LocalFileDownload from './types';
 
 /**

src/libs/localFileDownload/index.ts

@@ -1,4 +1,3 @@
-import * as FileUtils from '@libs/fileDownload/FileUtils';
 import localFileCreate from '@libs/localFileCreate';
 import type LocalFileDownload from './types';
 
@@ -8,9 +7,9 @@ import type LocalFileDownload from './types';
  * is downloaded by the browser.
  */
 const localFileDownload: LocalFileDownload = (fileName, textContent) => {
-    localFileCreate(fileName, textContent).then(({path}) => {
+    localFileCreate(`${fileName}.txt`, textContent).then(({path, newFileName}) => {
         const link = document.createElement('a');
-        link.download = FileUtils.appendTimeToFileName(`${fileName}.txt`);
+        link.download = newFileName;
         link.href = path;
         link.click();
     });

src/pages/settings/AboutPage/ConsolePage.tsx

@@ -42,7 +42,7 @@ type ConsolePageProps = ConsolePageOnyxProps;
  * @param logs Logs captured on the current device
  * @returns CapturedLogs with parsed messages
  */
-const parseStingifiedMessages = (logs: Log[]) => {
+const parseStringifyMessages = (logs: Log[]) => {
     if (isEmpty(logs)) {
         return;
     }
@@ -77,8 +77,7 @@ function ConsolePage({capturedLogs, shouldStoreLogs}: ConsolePageProps) {
         }
 
         setLogs((prevLogs) => ({...prevLogs, ...capturedLogs}));
-        // eslint-disable-next-line react-hooks/exhaustive-deps
-    }, [capturedLogs]);
+    }, [capturedLogs, shouldStoreLogs]);
 
     const executeArbitraryCode = () => {
         const sanitizedInput = sanitizeConsoleInput(input);
@@ -91,14 +90,14 @@ function ConsolePage({capturedLogs, shouldStoreLogs}: ConsolePageProps) {
     useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ENTER, executeArbitraryCode);
 
     const saveLogs = () => {
-        const logsWithParsedMessages = parseStingifiedMessages(logsList);
+        const logsWithParsedMessages = parseStringifyMessages(logsList);
 
         localFileDownload('logs', JSON.stringify(logsWithParsedMessages, null, 2));
     };
 
     const shareLogs = () => {
         setIsGeneratingLogsFile(true);
-        const logsWithParsedMessages = parseStingifiedMessages(logsList);
+        const logsWithParsedMessages = parseStringifyMessages(logsList);
 
         // Generate a file with the logs and pass its path to the list of reports to share it with
         localFileCreate('logs', JSON.stringify(logsWithParsedMessages, null, 2)).then(({path, size}) => {