update with design

Expensify · Oct 15, 2024 · 1113ed6 · 1113ed6
1 parent 0d498e2
commit 1113ed6
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 9 deletions.
diff --git a/assets/images/attachment-not-found.svg b/assets/images/attachment-not-found.svg
diff --git a/src/components/Attachments/AttachmentCarousel/CarouselItem.tsx b/src/components/Attachments/AttachmentCarousel/CarouselItem.tsx
@@ -84,7 +84,7 @@ function CarouselItem({item, onPress, isFocused, isModalHovered}: CarouselItemPr
                     isHovered={isModalHovered}
                     isFocused={isFocused}
                     duration={item.duration}
-                    fallbackSource={Expensicons.Exclamation}
+                    fallbackSource={Expensicons.AttachmentNotFound}
                 />
             </View>
 

diff --git a/src/components/Attachments/AttachmentView/index.tsx b/src/components/Attachments/AttachmentView/index.tsx
@@ -226,18 +226,17 @@ function AttachmentView({
                 <View style={[styles.flexColumn, styles.alignItemsCenter, styles.justifyContentCenter]}>
                     <Icon
                         src={fallbackSource}
-                        height={variables.defaultAvatarPreviewSize}
-                        width={variables.defaultAvatarPreviewSize}
-                        additionalStyles={[styles.alignItemsCenter, styles.justifyContentCenter, styles.flex1]}
+                        width={variables.iconSizeSuperLarge}
+                        height={variables.iconSizeSuperLarge}
                         fill={theme.border}
                     />
                     <View>
                         <Text style={[styles.notFoundTextHeader]}>{translate('attachmentView.attachmentNotFound')}</Text>
-                        <Text>{translate('attachmentView.verifyAttachmentURL')}</Text>
                     </View>
                 </View>
             );
         }
+
         let imageSource = imageError && fallbackSource ? (fallbackSource as string) : (source as string);
 
         if (isHighResolution) {

diff --git a/src/components/Icon/Expensicons.ts b/src/components/Icon/Expensicons.ts
@@ -6,6 +6,7 @@ import ArrowDownLong from '@assets/images/arrow-down-long.svg';
 import ArrowRightLong from '@assets/images/arrow-right-long.svg';
 import ArrowRight from '@assets/images/arrow-right.svg';
 import ArrowUpLong from '@assets/images/arrow-up-long.svg';
+import AttachmentNotFound from '@assets/images/attachment-not-found.svg';
 import UpArrow from '@assets/images/arrow-up.svg';
 import ArrowsUpDown from '@assets/images/arrows-updown.svg';
 import AdminRoomAvatar from '@assets/images/avatars/admin-room.svg';
@@ -214,6 +215,7 @@ export {
     ArrowsUpDown,
     ArrowUpLong,
     ArrowDownLong,
+    AttachmentNotFound,
     Wrench,
     BackArrow,
     Bank,

diff --git a/src/languages/en.ts b/src/languages/en.ts
@@ -1940,8 +1940,7 @@ const translations = {
             afterLinkText: 'to view it.',
             formLabel: 'View PDF',
         },
-        attachmentNotFound: 'Attachment not found',
-        verifyAttachmentURL: 'Please verify that the file address is valid',
+        attachmentNotFound: 'Attachment not found'
     },
     messages: {
         errorMessageInvalidPhone: `Please enter a valid phone number without brackets or dashes. If you're outside the US, please include your country code (e.g. ${CONST.EXAMPLE_PHONE_NUMBER}).`,

diff --git a/src/languages/es.ts b/src/languages/es.ts
@@ -1959,8 +1959,7 @@ const translations = {
             afterLinkText: 'para verlo.',
             formLabel: 'Ver PDF',
         },
-        attachmentNotFound: 'Adjunto no encontrado',
-        verifyAttachmentURL: 'Por favor verifique que la URL del archivo sea válida'
+        attachmentNotFound: 'Adjunto no encontrado'
     },
     messages: {
         errorMessageInvalidPhone: `Por favor, introduce un número de teléfono válido sin paréntesis o guiones. Si reside fuera de Estados Unidos, por favor incluye el prefijo internacional (p. ej. ${CONST.EXAMPLE_PHONE_NUMBER}).`,