change type location, resolved comments

Expensify · Mar 26, 2024 · 24cf044 · 24cf044
1 parent fc683cb
commit 24cf044
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts
@@ -2286,9 +2286,8 @@ function createSplitsAndOnyxData(
         existingSplitChatReport = participants.length < 2 ? ReportUtils.getChatByParticipants(participantAccountIDs) : null;
     }
     let newChat: ReportUtils.OptimisticChatReport | EmptyObject = {};
-
+    const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID];
     if (!existingSplitChatReport && participants.length > 1) {
-        const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID];
         newChat = ReportUtils.buildOptimisticChatReport(
             allParticipantsAccountIDs,
             '',
@@ -2303,7 +2302,7 @@ function createSplitsAndOnyxData(
         );
     }
     if (isEmptyObject(newChat)) {
-        newChat = ReportUtils.buildOptimisticChatReport(participantAccountIDs);
+        newChat = ReportUtils.buildOptimisticChatReport(allParticipantsAccountIDs);
     }
     const splitChatReport = existingSplitChatReport ?? newChat;
     const isOwnPolicyExpenseChat = !!splitChatReport.isOwnPolicyExpenseChat;

diff --git a/src/pages/NewChatConfirmPage.tsx b/src/pages/NewChatConfirmPage.tsx
@@ -44,7 +44,7 @@ function NewChatConfirmPage({newGroupDraft, allPersonalDetails}: NewChatConfirmP
         if (!newGroupDraft?.participants) {
             return [];
         }
-        const options: Participant[] = newGroupDraft?.participants.map((participant) =>
+        const options: Participant[] = newGroupDraft.participants.map((participant) =>
             OptionsListUtils.getParticipantsOption({accountID: participant.accountID, login: participant.login, reportID: ''}, allPersonalDetails),
         );
         return options;

diff --git a/src/pages/NewChatPage.tsx b/src/pages/NewChatPage.tsx
@@ -26,11 +26,7 @@ import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type * as OnyxTypes from '@src/types/onyx';
-
-type SelectedParticipant = {
-    accountID: number;
-    login: string;
-};
+import type {SelectedParticipant} from '@src/types/onyx/NewGroupChatDraft';
 
 type NewChatPageWithOnyxProps = {
     /** All reports shared with the user */

diff --git a/src/types/onyx/NewGroupChatDraft.ts b/src/types/onyx/NewGroupChatDraft.ts
@@ -1,8 +1,11 @@
-import type {SelectedParticipant} from '@pages/NewChatPage';
+type SelectedParticipant = {
+    accountID: number;
+    login: string;
+};
 
 type NewGroupChatDraft = {
     participants: SelectedParticipant[];
     reportName: string;
 };
-
+export type {SelectedParticipant};
 export default NewGroupChatDraft;