Merge branch 'main' into tgolen-refactor-hocsideloading

.github/workflows/e2ePerformanceTests.yml

@@ -205,22 +205,61 @@ jobs:
           cat ./mainResults/Host_Machine_Files/\$WORKING_DIRECTORY/debug.log || true
           cat "./mainResults/Host_Machine_Files/\$WORKING_DIRECTORY/Test spec output.txt" || true
 
+      - name: Announce failed workflow in Slack
+        if: failure()
+        uses: 8398a7/action-slack@v3
+        with:
+          status: custom
+          custom_payload: |
+            {
+              channel: '#expensify-margelo',
+              attachments: [{
+                color: 'danger',
+                text: `💥 ${process.env.AS_REPO} E2E Test run failed failed on <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> workflow 💥`,
+              }]
+            }
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}
+
       - name: Unzip AWS Device Farm results
-        if: ${{ always() }}
+        if: always()
         run: unzip "Customer Artifacts.zip"
 
       - name: Print AWS Device Farm run results
-        if: ${{ always() }}
+        if: always()
         run: cat "./Host_Machine_Files/\$WORKING_DIRECTORY/output.md"
 
       - name: Check if test failed, if so post the results and add the DeployBlocker label
+        id: checkIfRegressionDetected
         run: |
           if grep -q '🔴' ./output.md; then
+            # Create an output to the GH action that the test failed:
+            echo "performanceRegressionDetected=true" >> "$GITHUB_OUTPUT"
+
             gh pr edit ${{ inputs.PR_NUMBER }} --add-label DeployBlockerCash
             gh pr comment ${{ inputs.PR_NUMBER }} -F ./output.md
             gh pr comment ${{ inputs.PR_NUMBER }} -b "@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker."
           else
+            echo "performanceRegressionDetected=false" >> "$GITHUB_OUTPUT"
             echo '✅ no performance regression detected'
           fi
         env:
           GITHUB_TOKEN: ${{ github.token }}
+
+      - name: 'Announce regression in Slack'
+        if: ${{ steps.checkIfRegressionDetected.outputs.performanceRegressionDetected == 'true' }}
+        uses: 8398a7/action-slack@v3
+        with:
+          status: custom
+          custom_payload: |
+            {
+              channel: '#newdot-performance',
+              attachments: [{
+                color: 'danger',
+                text: `🔴 Performance regression detected in PR ${{ inputs.PR_NUMBER }}\nDetected in <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> workflow.`,
+              }]
+            }
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}

.github/workflows/failureNotifier.yml

@@ -83,13 +83,13 @@ jobs:
                   `1. **Why the PR caused the job to fail?**\n` +
                   `2. **Address any underlying issues.**\n\n` +
                   `🐛 We appreciate your help in squashing this bug!`;
-                  github.rest.issues.create({
+                  await github.rest.issues.create({
                     owner: context.repo.owner,
                     repo: context.repo.repo,
                     title: issueTitle,
                     body: issueBody,
                     labels: [failureLabel, 'Daily'],
-                    assignees: [prMerger, prAuthor]
+                    assignees: [prMerger]
                   });
                 }
               }

__mocks__/@react-native-firebase/crashlytics.ts

@@ -0,0 +1,15 @@
+import type {FirebaseCrashlyticsTypes} from '@react-native-firebase/crashlytics';
+
+type CrashlyticsModule = Pick<FirebaseCrashlyticsTypes.Module, 'log' | 'recordError' | 'setCrashlyticsCollectionEnabled'>;
+
+type CrashlyticsMock = () => CrashlyticsModule;
+
+// <App> uses <ErrorBoundary> and we need to mock the imported crashlytics module
+// due to an error that happens otherwise https://github.com/invertase/react-native-firebase/issues/2475
+const crashlyticsMock: CrashlyticsMock = () => ({
+    log: jest.fn(),
+    recordError: jest.fn(),
+    setCrashlyticsCollectionEnabled: jest.fn(),
+});
+
+export default crashlyticsMock;

__mocks__/react-freeze.ts

@@ -0,0 +1,8 @@
+import type {Freeze as FreezeComponent} from 'react-freeze';
+
+const Freeze: typeof FreezeComponent = (props) => props.children as JSX.Element;
+
+export {
+    // eslint-disable-next-line import/prefer-default-export
+    Freeze,
+};

__mocks__/react-native-dev-menu.ts

@@ -0,0 +1,11 @@
+import type {addItem} from 'react-native-dev-menu';
+
+type ReactNativeDevMenuMock = {
+    addItem: typeof addItem;
+};
+
+const reactNativeDevMenuMock: ReactNativeDevMenuMock = {
+    addItem: jest.fn(),
+};
+
+export default reactNativeDevMenuMock;

android/app/build.gradle

@@ -98,8 +98,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1001043801
-        versionName "1.4.38-1"
+        versionCode 1001043806
+        versionName "1.4.38-6"
     }
 
     flavorDimensions "default"