Revert "Final touches"

This reverts commit 04d94db.
Expensify · Nov 26, 2024 · 2eb1bb9 · 2eb1bb9
1 parent 4ff355f
commit 2eb1bb9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 31 deletions.
diff --git a/src/components/ApprovalWorkflowSection.tsx b/src/components/ApprovalWorkflowSection.tsx
@@ -1,5 +1,4 @@
-/* eslint-disable react/function-component-definition */
-import React, {useCallback, useMemo, useRef} from 'react';
+import React, {useCallback, useMemo} from 'react';
 import {View} from 'react-native';
 import useLocalize from '@hooks/useLocalize';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
@@ -21,36 +20,11 @@ type ApprovalWorkflowSectionProps = {
     onPress: () => void;
 };
 
-const Test = () => {
-    const styles = useThemeStyles();
-    const theme = useTheme();
-    const {shouldUseNarrowLayout} = useResponsiveLayout();
-    const {translate, toLocaleOrdinal} = useLocalize();
-
-    const approverTitle = useCallback(
-        (index: number) =>
-            approvalWorkflow.approvers.length > 1 ? `${toLocaleOrdinal(index + 1, true)} ${translate('workflowsPage.approver').toLowerCase()}` : `${translate('workflowsPage.approver')}`,
-        [approvalWorkflow.approvers.length, toLocaleOrdinal, translate],
-    );
-
-    const members = useMemo(() => {
-        if (approvalWorkflow.isDefault) {
-            return translate('workspace.common.everyone');
-        }
-
-        return OptionsListUtils.sortAlphabetically(approvalWorkflow.members, 'displayName')
-            .map((m) => m.displayName)
-            .join(', ');
-    }, [approvalWorkflow.isDefault, translate]);
-
-    return <View />;
-};
-
 function ApprovalWorkflowSection({approvalWorkflow, onPress}: ApprovalWorkflowSectionProps) {
     const styles = useThemeStyles();
     const theme = useTheme();
-    const {shouldUseNarrowLayout} = useResponsiveLayout();
     const {translate, toLocaleOrdinal} = useLocalize();
+    const {shouldUseNarrowLayout} = useResponsiveLayout();
 
     const approverTitle = useCallback(
         (index: number) =>
@@ -66,7 +40,7 @@ function ApprovalWorkflowSection({approvalWorkflow, onPress}: ApprovalWorkflowSe
         return OptionsListUtils.sortAlphabetically(approvalWorkflow.members, 'displayName')
             .map((m) => m.displayName)
             .join(', ');
-    }, [approvalWorkflow]);
+    }, [approvalWorkflow.isDefault, approvalWorkflow.members, translate]);
 
     return (
         <PressableWithoutFeedback
@@ -136,4 +110,4 @@ function ApprovalWorkflowSection({approvalWorkflow, onPress}: ApprovalWorkflowSe
     );
 }
 
-export {ApprovalWorkflowSection};
+export default ApprovalWorkflowSection;
diff --git a/src/components/AttachmentModal.tsx b/src/components/AttachmentModal.tsx
@@ -275,6 +275,7 @@ function AttachmentModal({
         }
 
         setIsModalOpen(false);
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
     }, [isModalOpen, isConfirmButtonDisabled, onConfirm, file, sourceState]);
 
     /**
@@ -457,7 +458,8 @@ function AttachmentModal({
             });
         }
         return menuItems;
-    }, [isReceiptAttachment, canEditReceipt, isOffline, allowDownload, isLocalSource, transaction, translate, closeModal, iouType, report?.reportID, downloadAttachment]);
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
+    }, [isReceiptAttachment, transaction, file, sourceState, iouType]);
 
     // There are a few things that shouldn't be set until we absolutely know if the file is a receipt or an attachment.
     // props.isReceiptAttachment will be null until its certain what the file is, in which case it will then be true|false.