add type check

Expensify · Nov 17, 2023 · 2f0e1ee · 2f0e1ee
1 parent 58d740c
commit 2f0e1ee
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/components/Modal/BaseModal.tsx b/src/components/Modal/BaseModal.tsx
@@ -72,7 +72,7 @@ function BaseModal(
 
     useEffect(() => {
         isVisibleRef.current = isVisible;
-        let removeOnCloseListener;
+        let removeOnCloseListener: () => void;
         if (isVisible) {
             Modal.willAlertModalBecomeVisible(true);
             // To handle closing any modal already visible when this modal is mounted, i.e. PopoverReportActionContextMenu

diff --git a/src/components/PopoverWithoutOverlay/index.js b/src/components/PopoverWithoutOverlay/index.js
@@ -12,7 +12,6 @@ import * as Modal from '@userActions/Modal';
 function Popover(props) {
     const styles = useThemeStyles();
     const {onOpen, close} = React.useContext(PopoverContext);
-
     const {modalStyle, modalContainerStyle, shouldAddTopSafeAreaMargin, shouldAddBottomSafeAreaMargin, shouldAddTopSafeAreaPadding, shouldAddBottomSafeAreaPadding} = getModalStyles(
         'popover',
         {

diff --git a/src/libs/actions/Modal.ts b/src/libs/actions/Modal.ts
@@ -30,8 +30,7 @@ function close(onModalCloseCallback: () => void, isNavigating = true) {
         return;
     }
     onModalClose = onModalCloseCallback;
-    const reverseCloseModals = [...closeModals].reverse();
-    reverseCloseModals.forEach((onClose) => {
+    [...closeModals].reverse().forEach((onClose) => {
         onClose(isNavigating);
     });
 }