use simple solution

Expensify · Jun 26, 2024 · 4041963 · 4041963
1 parent 3442ae8
commit 4041963
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/libs/SearchUtils.ts b/src/libs/SearchUtils.ts
@@ -26,7 +26,7 @@ const columnNamesToSortingProperty = {
     [CONST.SEARCH.TABLE_COLUMNS.CATEGORY]: 'category' as const,
     [CONST.SEARCH.TABLE_COLUMNS.TYPE]: 'type' as const,
     [CONST.SEARCH.TABLE_COLUMNS.ACTION]: 'action' as const,
-    [CONST.SEARCH.TABLE_COLUMNS.DESCRIPTION]: 'comment.comment' as const,
+    [CONST.SEARCH.TABLE_COLUMNS.DESCRIPTION]: 'comment' as const,
     [CONST.SEARCH.TABLE_COLUMNS.TAX_AMOUNT]: null,
     [CONST.SEARCH.TABLE_COLUMNS.RECEIPT]: null,
 };
@@ -242,10 +242,6 @@ function getQueryHash(query: string, policyID?: string, sortBy?: string, sortOrd
     return UserUtils.hashText(textToHash, 2 ** 32);
 }
 
-const getNestedValue = (obj: any, path: string) => {
-    return path.split('.').reduce((acc, part) => acc && acc[part], obj);
-};
-
 function getSortedTransactionData(data: TransactionListItemType[], sortBy?: SearchColumnType, sortOrder?: SortOrder) {
     if (!sortBy || !sortOrder) {
         return data;
@@ -258,8 +254,8 @@ function getSortedTransactionData(data: TransactionListItemType[], sortBy?: Sear
     }
 
     return data.sort((a, b) => {
-        const aValue = getNestedValue(a, sortingProperty);
-        const bValue = getNestedValue(b, sortingProperty);
+        const aValue = sortingProperty === 'comment' ? a.comment.comment : a[sortingProperty];
+        const bValue = sortingProperty === 'comment' ? b.comment.comment : b[sortingProperty];
 
         if (aValue === undefined || bValue === undefined) {
             return 0;