Skip to content

Commit

Permalink
Update with new profiles for Notification Service
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGable committed Dec 19, 2023
1 parent 9115cc8 commit 44d09e5
Show file tree
Hide file tree
Showing 11 changed files with 36 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/verifyPodfile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ declare EXIT_CODE=0

# Check Provisioning Style. If automatic signing is enabled, iOS builds will fail, so ensure we always have the proper profile specified
info "Verifying that automatic signing is not enabled"
if grep -q 'PROVISIONING_PROFILE_SPECIFIER = chat_expensify_appstore' ios/NewExpensify.xcodeproj/project.pbxproj; then
if grep -q 'PROVISIONING_PROFILE_SPECIFIER = NewApp_AppStore' ios/NewExpensify.xcodeproj/project.pbxproj; then
success "Automatic signing not enabled"
else
error "Error: Automatic provisioning style is not allowed!"
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ The GitHub workflows require a large list of secrets to deploy, notify and test
1. `LARGE_SECRET_PASSPHRASE` - decrypts secrets stored in various encrypted files stored in GitHub repository. To create updated versions of these encrypted files, refer to steps 1-4 of [this encrypted secrets help page](https://docs.github.com/en/actions/reference/encrypted-secrets#limits-for-secrets) using the `LARGE_SECRET_PASSPHRASE`.
1. `android/app/my-upload-key.keystore.gpg`
1. `android/app/android-fastlane-json-key.json.gpg`
1. `ios/expensify_chat_adhoc.mobileprovision.gpg`
1. `ios/chat_expensify_appstore.mobileprovision.gpg`
1. `ios/NewApp_AdHoc.mobileprovision`
1. `ios/NewApp_AdHoc_Notification_Service.mobileprovision`
1. `ios/NewApp_AppStore.mobileprovision.gpg`
1. `ios/NewApp_AppStore_Notification_Service.mobileprovision.gpg`
1. `ios/Certificates.p12.gpg`
1. `SLACK_WEBHOOK` - Sends Slack notifications via Slack WebHook https://expensify.slack.com/services/B01AX48D7MM
1. `OS_BOTIFY_TOKEN` - Personal access token for @OSBotify user in GitHub
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/platformDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
with:
distribution: 'oracle'
java-version: '17'

- name: Setup Ruby
uses: ruby/setup-ruby@a05e47355e80e57b9a67566a813648fa67d92011
with:
Expand Down Expand Up @@ -211,8 +211,13 @@ jobs:
max_attempts: 5
command: cd ios && bundle exec pod install

- name: Decrypt profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output chat_expensify_appstore.mobileprovision chat_expensify_appstore.mobileprovision.gpg
- name: Decrypt AppStore profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output NewApp_AppStore.mobileprovision NewApp_AppStore.mobileprovision.gpg
env:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

- name: Decrypt AppStore Notification Service profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output NewApp_AppStore_Notification_Service.mobileprovision NewApp_AppStore_Notification_Service.mobileprovision.gpg
env:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/testBuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,13 @@ jobs:
max_attempts: 5
command: cd ios && bundle exec pod install

- name: Decrypt profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output expensify_chat_adhoc.mobileprovision expensify_chat_adhoc.mobileprovision.gpg
- name: Decrypt AdHoc profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output NewApp_AdHoc.mobileprovision NewApp_AdHoc.mobileprovision.gpg
env:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

- name: Decrypt AdHoc Notification Service profile
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output NewApp_AdHoc_Notification_Service.mobileprovision NewApp_AdHoc_Notification_Service.mobileprovision.gpg
env:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

Expand Down
20 changes: 16 additions & 4 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -161,19 +161,27 @@ platform :ios do
)

install_provisioning_profile(
path: "./ios/expensify_chat_adhoc.mobileprovision"
path: "./ios/NewApp_AdHoc.mobileprovision"
)

install_provisioning_profile(
path: "./ios/NewApp_AdHoc_Notification_Service.mobileprovision"
)

build_app(
workspace: "./ios/NewExpensify.xcworkspace",
skip_profile_detection: true,
scheme: "New Expensify AdHoc",
xcargs: { :PROVISIONING_PROFILE_SPECIFIER => "expensify_chat_adhoc", },
xcargs: {
:PROVISIONING_PROFILE_SPECIFIER => "NewApp_AdHoc",
:PROVISIONING_PROFILE_SPECIFIER => "NewApp_AdHoc_Notification_Service",
},
export_method: "ad-hoc",
export_options: {
method: "ad-hoc",
provisioningProfiles: {
"com.expensify.chat.adhoc" => "expensify_chat_adhoc",
"com.expensify.chat.adhoc" => "NewApp_AdHoc",
"com.expensify.chat.adhoc.NotificationServiceExtension" => "NewApp_AdHoc_Notification_Service",
},
manageAppVersionAndBuildNumber: false
}
Expand Down Expand Up @@ -215,7 +223,11 @@ platform :ios do
)

install_provisioning_profile(
path: "./ios/chat_expensify_appstore.mobileprovision"
path: "./ios/NewApp_AppStore.mobileprovision"
)

install_provisioning_profile(
path: "./ios/NewApp_AppStore_Notification_Service.mobileprovision"
)

build_app(
Expand Down
Binary file added ios/NewApp_AdHoc.mobileprovision.gpg
Binary file not shown.
Binary file not shown.
Binary file added ios/NewApp_AppStore.mobileprovision.gpg
Binary file not shown.
Binary file not shown.
Binary file removed ios/chat_expensify_appstore.mobileprovision.gpg
Binary file not shown.
Binary file removed ios/expensify_chat_adhoc.mobileprovision.gpg
Binary file not shown.

0 comments on commit 44d09e5

Please sign in to comment.