Merge pull request #40563 from neonbhai/group-chat-fixes

[Group Chats] Fixes for Thread Avatars and Leave Group Chat Navigation
Expensify · Apr 19, 2024 · 48f64d0 · 48f64d0
2 parents 09ad468 + 7071f2e
commit 48f64d0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 23 deletions.
diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts
@@ -2421,7 +2421,7 @@ function navigateToMostRecentReport(currentReport: OnyxEntry<Report>) {
         if (!isChatThread) {
             Navigation.goBack();
         }
-        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? ''));
+        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? ''), CONST.NAVIGATION.TYPE.FORCED_UP);
     } else {
         const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
         const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
@@ -2430,7 +2430,7 @@ function navigateToMostRecentReport(currentReport: OnyxEntry<Report>) {
             if (!isChatThread) {
                 Navigation.goBack();
             }
-            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat?.reportID));
+            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat?.reportID), CONST.NAVIGATION.TYPE.FORCED_UP);
         }
     }
 }

diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx
@@ -82,6 +82,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
     const chatRoomSubtitle = useMemo(() => ReportUtils.getChatRoomSubtitle(report), [report, policy]);
     const parentNavigationSubtitleData = ReportUtils.getParentNavigationSubtitle(report);
     const isGroupChat = useMemo(() => ReportUtils.isGroupChat(report), [report]);
+    const isThread = useMemo(() => ReportUtils.isThread(report), [report]);
     const participants = useMemo(() => {
         if (isGroupChat) {
             return ReportUtils.getParticipantAccountIDs(report.reportID ?? '');
@@ -227,27 +228,28 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
         />
     ) : null;
 
-    const renderAvatar = isGroupChat ? (
-        <AvatarWithImagePicker
-            source={icons[0].source}
-            isUsingDefaultAvatar={!report.avatarUrl}
-            size={CONST.AVATAR_SIZE.XLARGE}
-            avatarStyle={styles.avatarXLarge}
-            shouldDisableViewPhoto
-            onImageRemoved={() => {
-                // Calling this without a file will remove the avatar
-                Report.updateGroupChatAvatar(report.reportID ?? '');
-            }}
-            onImageSelected={(file) => Report.updateGroupChatAvatar(report.reportID ?? '', file)}
-            editIcon={Expensicons.Camera}
-            editIconStyle={styles.smallEditIconAccount}
-        />
-    ) : (
-        <RoomHeaderAvatars
-            icons={icons}
-            reportID={report?.reportID}
-        />
-    );
+    const renderAvatar =
+        isGroupChat && !isThread ? (
+            <AvatarWithImagePicker
+                source={icons[0].source}
+                isUsingDefaultAvatar={!report.avatarUrl}
+                size={CONST.AVATAR_SIZE.XLARGE}
+                avatarStyle={styles.avatarXLarge}
+                shouldDisableViewPhoto
+                onImageRemoved={() => {
+                    // Calling this without a file will remove the avatar
+                    Report.updateGroupChatAvatar(report.reportID ?? '');
+                }}
+                onImageSelected={(file) => Report.updateGroupChatAvatar(report.reportID ?? '', file)}
+                editIcon={Expensicons.Camera}
+                editIconStyle={styles.smallEditIconAccount}
+            />
+        ) : (
+            <RoomHeaderAvatars
+                icons={icons}
+                reportID={report?.reportID}
+            />
+        );
 
     const reportName =
         ReportUtils.isDeprecatedGroupDM(report) || ReportUtils.isGroupChat(report)