Skip to content

Commit

Permalink
fix PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
SzymczakJ committed May 28, 2024
1 parent adddbcd commit 4ce01d2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/components/MenuItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ type MenuItemBaseProps = {
hintText?: MaybePhraseKey;

/** Should the error text red dot indicator be shown */
shouldShowErrorTextRedDot?: boolean;
shouldShowRedDotIndicator?: boolean;

/** A boolean flag that gives the icon a green fill if true */
success?: boolean;
Expand Down Expand Up @@ -315,7 +315,7 @@ function MenuItem(
helperTextStyle,
errorText,
errorTextStyle,
shouldShowErrorTextRedDot,
shouldShowRedDotIndicator,
hintText,
success = false,
focused = false,
Expand Down Expand Up @@ -691,7 +691,7 @@ function MenuItem(
{!!errorText && (
<FormHelpMessage
isError
shouldShowRedDotIndicator={!!shouldShowErrorTextRedDot}
shouldShowRedDotIndicator={!!shouldShowRedDotIndicator}
message={errorText}
style={[styles.menuItemError, errorTextStyle]}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/accounting/PolicyAccountingPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function PolicyAccountingPage({policy, connectionSyncProgress}: PolicyAccounting
title: integrationData?.title,
errorText: shouldShowSynchronizationError ? translate('workspace.accounting.syncError', connectedIntegration) : undefined,
errorTextStyle: [styles.mt5],
shouldShowErrorTextRedDot: true,
shouldShowRedDotIndicator: true,
description: isSyncInProgress
? translate('workspace.accounting.connections.syncStageName', connectionSyncProgress.stageInProgress)
: translate('workspace.accounting.lastSync'),
Expand Down

0 comments on commit 4ce01d2

Please sign in to comment.