chore: changes after review

Expensify · Jun 3, 2024 · 50ad7b8 · 50ad7b8
1 parent a4d89b0
commit 50ad7b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/e2e/config.ts b/tests/e2e/config.ts
@@ -68,12 +68,11 @@ export default {
     TESTS_CONFIG: {
         [TEST_NAMES.AppStartTime]: {
             name: TEST_NAMES.AppStartTime,
-
+            warmupRuns: 1,
             // ... any additional config you might need
         },
         [TEST_NAMES.OpenChatFinderPage]: {
             name: TEST_NAMES.OpenChatFinderPage,
-            requiresDoubleWarmup: true,
         },
         // TODO: Fix text and enable again
         // [TEST_NAMES.ReportTyping]: {
@@ -83,13 +82,11 @@ export default {
         //     },
         //     // Crowded Policy (Do Not Delete) Report, has a input bar available:
         //     reportID: '8268282951170052',
-        //     requiresDoubleWarmup: true,
         // },
         [TEST_NAMES.ChatOpening]: {
             name: TEST_NAMES.ChatOpening,
             // #announce Chat with many messages
             reportID: '5421294415618529',
-            requiresDoubleWarmup: true,
         },
         // TODO: fix and enable again
         // [TEST_NAMES.Linking]: {
@@ -101,7 +98,6 @@ export default {
         //     reportID: '8268282951170052',
         //     linkedReportID: '5421294415618529',
         //     linkedReportActionID: '2845024374735019929',
-        //     requiresDoubleWarmup: true,
         // },
     },
 };

diff --git a/tests/e2e/testRunner.ts b/tests/e2e/testRunner.ts
@@ -181,8 +181,10 @@ const runTests = async (): Promise<void> => {
 
         const warmupText = `Warmup for test '${test.name}' [${testIndex + 1}/${tests.length}]`;
 
-        const requiresDoubleWarmup = test.requiresDoubleWarmup ?? false;
-        const iterations = requiresDoubleWarmup ? 2 : 1;
+        // by default we do 2 warmups:
+        // - first warmup to pass a login flow
+        // - second warmup to pass an actual flow and cache network requests
+        const iterations = test.warmupRuns ?? 2;
         for (let i = 0; i < iterations; i++) {
             // Warmup the main app:
             await runTestIteration(config.MAIN_APP_PACKAGE, `[MAIN] ${warmupText}. Iteration ${i + 1}/${iterations}`);