fix: cr fixes

src/libs/DateUtils.ts

@@ -808,7 +808,7 @@ function doesDateBelongToAPastYear(date: string): boolean {
 
 /**
  * Returns a boolean value indicating whether the card has expired.
- * @param expiryMonth month when card expires
+ * @param expiryMonth month when card expires (starts from 1 so can be any number between 1 and 12)
  * @param expiryYear year when card expires
  */
 

src/pages/settings/Subscription/utils.ts

@@ -19,11 +19,4 @@ function getNewSubscriptionRenewalDate(): string {
     return format(startOfMonth(addMonths(new Date(), 12)), CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT);
 }
 
-function isCardExpired(expiryMonth: number, expiryYear: number): boolean {
-    const currentYear = new Date().getFullYear();
-    const currentMonth = new Date().getMonth() + 1;
-
-    return expiryYear < currentYear || (expiryYear === currentYear && expiryMonth < currentMonth);
-}
-
-export {getNewSubscriptionRenewalDate, formatSubscriptionEndDate, isCardExpired};
+export {getNewSubscriptionRenewalDate, formatSubscriptionEndDate};

tests/unit/DateUtilsTest.ts

@@ -265,4 +265,18 @@ describe('DateUtils', () => {
             expect(lastBusinessDay).toEqual(expectedResult);
         });
     });
+
+    describe('isCardExpired', () => {
+        it('should return true when the card is expired', () => {
+            const cardMonth = 1;
+            const cardYear = new Date().getFullYear() - 1;
+            expect(DateUtils.isCardExpired(cardMonth, cardYear)).toBe(true);
+        });
+
+        it('should return false when the card is not expired', () => {
+            const cardMonth = 1;
+            const cardYear = new Date().getFullYear() + 1;
+            expect(DateUtils.isCardExpired(cardMonth, cardYear)).toBe(false);
+        });
+    });
 });