Skip to content

Commit

Permalink
Update as suggested.
Browse files Browse the repository at this point in the history
Signed-off-by: Krishna Gupta <[email protected]>
  • Loading branch information
Krishna2323 committed Feb 29, 2024
1 parent 0373f6b commit 580a53e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions src/components/Checkbox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ function Checkbox(
aria-checked={isChecked}
accessibilityLabel={accessibilityLabel}
pressDimmingValue={1}
// Explicitly need to add this because getCheckboxPressableStyle returns `cursorPointer` which will override disabled cursor style determined by `disabled` prop
disabledStyle={styles.cursorDisabled}
>
{children ?? (
<View
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function BaseListItem<TItem extends ListItem>({
accessibilityLabel={item.text}
role={CONST.ROLE.BUTTON}
onPress={handleCheckboxPress}
style={StyleUtils.getCheckboxPressableStyle()}
style={[styles.cursorUnset, StyleUtils.getCheckboxPressableStyle()]}
>
<View style={selectMultipleStyle}>
{item.isSelected && (
Expand Down
2 changes: 0 additions & 2 deletions src/styles/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import type {ThemeStyles} from '..';
import shouldPreventScrollOnAutoCompleteSuggestion from './autoCompleteSuggestion';
import getCardStyles from './cardStyles';
import containerComposeStyles from './containerComposeStyles';
import cursor from './cursor';
import FontUtils from './FontUtils';
import createModalStyleUtils from './generators/ModalStyleUtils';
import createReportActionContextMenuStyleUtils from './generators/ReportActionContextMenuStyleUtils';
Expand Down Expand Up @@ -929,7 +928,6 @@ function getCheckboxPressableStyle(borderRadius = 6): ViewStyle {
alignItems: 'center',
// eslint-disable-next-line object-shorthand
borderRadius: borderRadius,
...cursor.cursorPointer,
};
}

Expand Down

0 comments on commit 580a53e

Please sign in to comment.