Skip to content

Commit

Permalink
Merge pull request #35406 from brunovjk/ts-migration/31988
Browse files Browse the repository at this point in the history
[TS migration] Migrate 'SignInDesktop' page
  • Loading branch information
youssef-lr authored Feb 12, 2024
2 parents c477054 + 552b78d commit 5aee9a3
Show file tree
Hide file tree
Showing 9 changed files with 28 additions and 20 deletions.
9 changes: 0 additions & 9 deletions src/pages/signin/AppleSignInDesktopPage/index.website.js

This file was deleted.

14 changes: 14 additions & 0 deletions src/pages/signin/AppleSignInDesktopPage/index.website.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import React from 'react';
import ThirdPartySignInPage from '@pages/signin/ThirdPartySignInPage';
import CONST from '@src/CONST';

function AppleSignInDesktopPage() {
return (
<ThirdPartySignInPage
// @ts-expect-error TODO: Remove this once SignIn (https://github.com/Expensify/App/issues/25224) is migrated to TypeScript.
signInProvider={CONST.SIGN_IN_METHOD.APPLE}
/>
);
}

export default AppleSignInDesktopPage;
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import * as App from '@userActions/App';
* Landing page for when a user enters third party login flow on desktop.
* Allows user to open the link in browser if they accidentally canceled the auto-prompt.
* Also allows them to continue to the web app if they want to use it there.
*
* @returns {React.Component}
*/
function DesktopRedirectPage() {
return <DeeplinkRedirectLoadingIndicator openLinkInBrowser={App.beginDeepLinkRedirect} />;
Expand Down
9 changes: 0 additions & 9 deletions src/pages/signin/GoogleSignInDesktopPage/index.website.js

This file was deleted.

14 changes: 14 additions & 0 deletions src/pages/signin/GoogleSignInDesktopPage/index.website.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import React from 'react';
import ThirdPartySignInPage from '@pages/signin/ThirdPartySignInPage';
import CONST from '@src/CONST';

function GoogleSignInDesktopPage() {
return (
<ThirdPartySignInPage
// @ts-expect-error TODO: Remove this once SignIn (https://github.com/Expensify/App/issues/25224) is migrated to TypeScript.
signInProvider={CONST.SIGN_IN_METHOD.GOOGLE}
/>
);
}

export default GoogleSignInDesktopPage;

0 comments on commit 5aee9a3

Please sign in to comment.