Rename variables

Expensify · Aug 13, 2024 · 5f3f64f · 5f3f64f
1 parent 69ab537
commit 5f3f64f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/components/FormHelpMessage.tsx b/src/components/FormHelpMessage.tsx
@@ -27,15 +27,15 @@ type FormHelpMessageProps = {
     shouldShowRedDotIndicator?: boolean;
 
     /** Whether should render error text as HTML or as Text */
-    shouldParseMessage?: boolean;
+    shouldRenderMessageAsHTML?: boolean;
 };
 
-function FormHelpMessage({message = '', children, isError = true, style, shouldShowRedDotIndicator = true, shouldParseMessage = false}: FormHelpMessageProps) {
+function FormHelpMessage({message = '', children, isError = true, style, shouldShowRedDotIndicator = true, shouldRenderMessageAsHTML = false}: FormHelpMessageProps) {
     const theme = useTheme();
     const styles = useThemeStyles();
 
-    const processedText = useMemo(() => {
-        if (typeof message !== 'string' || !shouldParseMessage) {
+    const HTMLMessage = useMemo(() => {
+        if (typeof message !== 'string' || !shouldRenderMessageAsHTML) {
             return '';
         }
 
@@ -46,7 +46,7 @@ function FormHelpMessage({message = '', children, isError = true, style, shouldS
         }
 
         return `<muted-text-label>${replacedText}</muted-text-label>`;
-    }, [isError, message, shouldParseMessage]);
+    }, [isError, message, shouldRenderMessageAsHTML]);
 
     if (isEmpty(message) && isEmpty(children)) {
         return null;
@@ -61,7 +61,7 @@ function FormHelpMessage({message = '', children, isError = true, style, shouldS
                 />
             )}
             <View style={[styles.flex1, isError && shouldShowRedDotIndicator ? styles.ml2 : {}]}>
-                {children ?? (shouldParseMessage ? <RenderHTML html={processedText} /> : <Text style={[isError ? styles.formError : styles.formHelp, styles.mb0]}>{message}</Text>)}
+                {children ?? (shouldRenderMessageAsHTML ? <RenderHTML html={HTMLMessage} /> : <Text style={[isError ? styles.formError : styles.formHelp, styles.mb0]}>{message}</Text>)}
             </View>
         </View>
     );

diff --git a/src/components/MenuItem.tsx b/src/components/MenuItem.tsx
@@ -262,10 +262,10 @@ type MenuItemBaseProps = {
     shouldParseHelperText?: boolean;
 
     /** Whether should render hint text as HTML or as Text */
-    shouldParseHintText?: boolean;
+    shouldRenderHintAsHTML?: boolean;
 
     /** Whether should render error text as HTML or as Text */
-    shouldParseErrorText?: boolean;
+    shouldRenderErrorAsHTML?: boolean;
 
     /** Should check anonymous user in onPress function */
     shouldCheckActionAllowedOnPress?: boolean;
@@ -400,8 +400,8 @@ function MenuItem(
         shouldBlockSelection = false,
         shouldParseTitle = false,
         shouldParseHelperText = false,
-        shouldParseHintText = false,
-        shouldParseErrorText = false,
+        shouldRenderHintAsHTML = false,
+        shouldRenderErrorAsHTML = false,
         shouldCheckActionAllowedOnPress = true,
         onSecondaryInteraction,
         titleWithTooltips,
@@ -810,7 +810,7 @@ function MenuItem(
                                                 shouldShowRedDotIndicator={!!shouldShowRedDotIndicator}
                                                 message={errorText}
                                                 style={[styles.menuItemError, errorTextStyle]}
-                                                shouldParseMessage={shouldParseErrorText}
+                                                shouldRenderMessageAsHTML={shouldRenderErrorAsHTML}
                                             />
                                         )}
                                         {!!hintText && (
@@ -819,7 +819,7 @@ function MenuItem(
                                                 shouldShowRedDotIndicator={false}
                                                 message={hintText}
                                                 style={styles.menuItemError}
-                                                shouldParseMessage={shouldParseHintText}
+                                                shouldRenderMessageAsHTML={shouldRenderHintAsHTML}
                                             />
                                         )}
                                     </View>

diff --git a/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx b/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx
@@ -106,10 +106,10 @@ function ApprovalWorkflowEditor({approvalWorkflow, policyID}: ApprovalWorkflowEd
                             }
                             shouldShowRightIcon
                             hintText={hintText}
-                            shouldParseHintText
+                            shouldRenderHintAsHTML
                             brickRoadIndicator={errorText ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
                             errorText={errorText}
-                            shouldParseErrorText
+                            shouldRenderErrorAsHTML
                         />
                     );
                 })}