Skip to content

Commit

Permalink
Remove memory leak comment
Browse files Browse the repository at this point in the history
  • Loading branch information
layacat committed Oct 8, 2024
1 parent bd70f71 commit 622b892
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/components/Lottie/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ function Lottie({source, webStyle, shouldLoadAfterInteractions, ...props}: Props

// If the page navigates to another screen, the image fails to load, app is in background state, animation file isn't ready, or the splash screen isn't hidden yet,
// we'll just render an empty view as the fallback to prevent
// 1. memory leak, see issue: https://github.com/Expensify/App/issues/36645
// 2. heavy rendering, see issues: https://github.com/Expensify/App/issues/34696 and https://github.com/Expensify/App/issues/47273
// 3. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
// 1. heavy rendering, see issues: https://github.com/Expensify/App/issues/34696 and https://github.com/Expensify/App/issues/47273
// 2. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
if (isError || appState.isBackground || !animationFile || splashScreenState !== CONST.BOOT_SPLASH_STATE.HIDDEN || (!isInteractionComplete && shouldLoadAfterInteractions)) {
return <View style={[aspectRatioStyle, props.style]} />;
}
Expand Down

0 comments on commit 622b892

Please sign in to comment.